[quant][graphmode][fix] docs for InsertObservers#35557
Closed
jerryzh168 wants to merge 12 commits intogh/jerryzh168/276/basefrom
Closed
[quant][graphmode][fix] docs for InsertObservers#35557jerryzh168 wants to merge 12 commits intogh/jerryzh168/276/basefrom
jerryzh168 wants to merge 12 commits intogh/jerryzh168/276/basefrom
Conversation
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 27, 2020
Closed
This was referenced Mar 27, 2020
💊 CircleCI build failures summary and remediationsAs of commit 71584d4 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 66 times. |
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
reviewed
Mar 30, 2020
| std::unordered_map<Value*, std::unordered_set<Value*>> boundary_value_map_; | ||
| std::unordered_set<Value*> observed_values_; | ||
| // This is used for the observed values to pass through the ops like flatten, | ||
| // so that output value of flatten do not need to be observed |
Contributor
There was a problem hiding this comment.
nit: does not need to be observed.
supriyar
approved these changes
Mar 30, 2020
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: . Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 8add184. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35557 . Test Plan: . Imported from OSS Differential Revision: D20752129 fbshipit-source-id: 1cde20675c4f19fd59116332cae4a444e58973c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
.
Test Plan:
.
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20752129