[quant][graphmode] Add prim::ListConstruct to general op handling#34345
Closed
jerryzh168 wants to merge 23 commits intogh/jerryzh168/237/basefrom
Closed
[quant][graphmode] Add prim::ListConstruct to general op handling#34345jerryzh168 wants to merge 23 commits intogh/jerryzh168/237/basefrom
jerryzh168 wants to merge 23 commits intogh/jerryzh168/237/basefrom
Conversation
This was referenced Mar 6, 2020
Closed
Closed
💊 CircleCI build failures summary and remediationsAs of commit a1635f9 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 154 times. |
This was referenced Mar 7, 2020
| /* call_funcs = */ {}, | ||
| /* aten_funcs = */ single_input_aten_funcs)) { | ||
| return {0}; | ||
| } else if (n->kind() == prim::ListConstruct) { |
Contributor
There was a problem hiding this comment.
Can you add a test that exercises this code?
This was referenced Mar 10, 2020
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat #34346 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat #34346 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
This was referenced Mar 19, 2020
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat #34346 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat #34346 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
This was referenced Mar 21, 2020
Closed
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
…andling" Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20524455](https://our.internmc.facebook.com/intern/diff/D20524455) [ghstack-poisoned]
Contributor
|
This pull request has been merged in cd75d4e. |
okly366
pushed a commit
to okly366/pytorch
that referenced
this pull request
Apr 26, 2020
Summary: prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: a75826e Pull Request resolved: pytorch/pytorch#34345
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#34345) Summary: Pull Request resolved: pytorch#34345 prim::ListConstruct is similar to an op that doesn't require observation we want to make sure we can propagate observed property through it Test Plan: this will be tested when we add support for cat pytorch#34346 Imported from OSS Differential Revision: D20524455 fbshipit-source-id: b5f8e0c8776d48d588aeba6735de06dcd308560e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
prim::ListConstruct is similar to an op that doesn't require observation
we want to make sure we can propagate observed property through it
Test Plan:
this will be tested when we add support for cat
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20524455