[quant][graphmode][fix] preserve the type of original value when inserting dequant node#34349
Closed
jerryzh168 wants to merge 30 commits intogh/jerryzh168/241/basefrom
Closed
[quant][graphmode][fix] preserve the type of original value when inserting dequant node#34349jerryzh168 wants to merge 30 commits intogh/jerryzh168/241/basefrom
jerryzh168 wants to merge 30 commits intogh/jerryzh168/241/basefrom
Conversation
…rting dequant node Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 6, 2020
Closed
💊 CircleCI build failures summary and remediationsAs of commit cf01f1e (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 2 upstream failures:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 134 times. |
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
| graph->create(Symbol::aten("dequantize"), {quantized_val}); | ||
| dequant->output()->setDebugName( | ||
| original_val->debugName() + ".dequant." + c10::guts::to_string(i)); | ||
| original_val->debugName() + ".dequant." + c10::guts::to_string(i)) |
Contributor
There was a problem hiding this comment.
If this was an issue that needed a fix, suggest having a simple test that checks for the type
Contributor
Author
There was a problem hiding this comment.
this actually only can happen when we do swap dequantize for list of tensors, and it will be tested later in the stack
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 10, 2020
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
This was referenced Mar 19, 2020
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
This was referenced Mar 21, 2020
Closed
…e when inserting dequant node" Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504456](https://our.internmc.facebook.com/intern/diff/D20504456) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 4caa0db. |
okly366
pushed a commit
to okly366/pytorch
that referenced
this pull request
Apr 26, 2020
…rting dequant node Summary: Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: 85ecb25 Pull Request resolved: pytorch/pytorch#34349
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…rting dequant node (pytorch#34349) Summary: Pull Request resolved: pytorch#34349 Set the output type of dequantize node to the type of original value this is to fix swap dequantize tensor list Test Plan: . Imported from OSS Differential Revision: D20504456 fbshipit-source-id: 9064d7d598a4310e27e2914a072097526448a02c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Set the output type of dequantize node to the type of original value
this is to fix swap dequantize tensor list
Test Plan:
.
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20504456