[quant][graphmode] quantization support for aten::add by jerryzh168 · Pull Request #34572 · pytorch/pytorch

jerryzh168 · 2020-03-11T02:27:05Z

Stack from ghstack:

[quant][graphmode] Make interpolate/upsample work again #35130 [quant][graphmode] Make interpolate/upsample work again
[quant][graphmode] SwapDeQuant support prim::If #35142 [quant][graphmode] SwapDeQuant support prim::If
[quant][graphmode][refactor] getGeneralOpTensorInputIndexes -> getGeneralOpTensorInputs #35141 [quant][graphmode][refactor] getGeneralOpTensorInputIndexes -> getGeneralOpTensorInputs
[quant][graphmode][refactor] swapDeQuant takes block as arugment #35135 [quant][graphmode][refactor] swapDeQuant takes block as arugment
[quant][graphmode] Fold quantized prepacking ops #35077 [quant][graphmode] Fold quantized prepacking ops
[quant] Make conv2d_prepack and linear_prepack pure #35073 [quant] Make conv2d_prepack and linear_prepack pure
[quant][graphmode] quantization support for prim::CallFunction #34855 [quant][graphmode] quantization support for prim::CallFunction
[quant][graphmode] Add quantization support for aten::cat #34346 [quant][graphmode] Add quantization support for aten::cat
[quant][graphmode] Add prim::ListConstruct to general op handling #34345 [quant][graphmode] Add prim::ListConstruct to general op handling
[quant][graphmode] quantization support for view, transpose, contiguos #34854 [quant][graphmode] quantization support for view, transpose, contiguos
[quant][graphmode] quantization support for aten::chunk #34806 [quant][graphmode] quantization support for aten::chunk
[quant][graphmode] quantization support for prim::ListUnpack #34807 [quant][graphmode] quantization support for prim::ListUnpack
[quant][graphmode] Replicate quantize node for prim::If #34804 [quant][graphmode] Replicate quantize node for prim::If
[quant][graphmode] quantization support for aten::add #34572 [quant][graphmode] quantization support for aten::add

Summary:
This is only for Tensor - Tensor add, we'll need to support Tensor - Scalar add in a different way, since that does not need observer
Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D20519607

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

dr-ci · 2020-03-11T05:51:14Z

💊 CircleCI build failures summary and remediations

As of commit 3657a7b (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

1/1 broken upstream at merge base a00e12e since Mar 23
Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
```
If your commit is older than viable/strict:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
```
Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 134 times.

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: This adds support to Tensor add, we don't support scalar add right now, will support that later Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

Summary: This is only for Tensor - Tensor add, we'll need to support Tensor - Scalar add in a different way, since that does not need observer Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

facebook-github-bot · 2020-03-24T02:37:29Z

This pull request has been merged in eff68bc.

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3794351 Pull Request resolved: pytorch/pytorch#34572

Summary: Pull Request resolved: pytorch#34572 Test Plan: python test/test_jit.py Imported from OSS Differential Revision: D20519607 fbshipit-source-id: c57e062cffc24a47a76b73b58aff7f9ef80183fa

[quant][graphmode] quantization support for aten::add

c9fdd6b

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 requested a review from apaszke as a code owner March 11, 2020 02:27

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 11, 2020

Update on "[quant][graphmode] quantization support for aten::add"

c10b116

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 added 2 commits March 12, 2020 10:27

Update on "[quant][graphmode] quantization support for aten::add"

64010ad

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] quantization support for aten::add"

d1ca2c7

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] quantization support for aten::add"

e4e218f

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 added 4 commits March 19, 2020 10:31

This was referenced Mar 19, 2020

[quant][graphmode] Fold quantized prepacking ops #35072

Merged

[quant] Make conv2d_prepack and linear_prepack pure #35073

Closed

jerryzh168 mentioned this pull request Mar 20, 2020

[quant][graphmode] Fold quantized prepacking ops #35077

Closed

jerryzh168 added 4 commits March 19, 2020 17:26

Update on "[quant][graphmode] quantization support for aten::add"

801cae4

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

Update on "[quant][graphmode] quantization support for aten::add"

3dcb8ac

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

Update on "[quant][graphmode] quantization support for aten::add"

37b65a3

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 20, 2020

[quant][graphmode] Make interpolate/upsample work again #35130

Closed

Update on "[quant][graphmode] quantization support for aten::add"

bfdc5b1

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 20, 2020

[quant][graphmode][refactor] swapDeQuant takes block as arugment #35135

Closed

Update on "[quant][graphmode] quantization support for aten::add"

d0eca40

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

This was referenced Mar 21, 2020

[quant][graphmode][refactor] getGeneralOpTensorInputIndexes -> getGeneralOpTensorInputs #35141

Closed

[quant][graphmode] SwapDeQuant support prim::If #35142

Closed

jerryzh168 added 2 commits March 22, 2020 14:09

Update on "[quant][graphmode] quantization support for aten::add"

9b032c7

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

Update on "[quant][graphmode] quantization support for aten::add"

6055d6a

Summary: Test Plan: python test/test_jit.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607) [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 23, 2020

[quant][graphmode] weight/bias of linear/conv can be reused for multiple ops #35221

Closed

facebook-github-bot closed this in eff68bc Mar 24, 2020

facebook-github-bot added the merged label Mar 24, 2020

facebook-github-bot deleted the gh/jerryzh168/247/head branch March 27, 2020 14:16

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[quant][graphmode] quantization support for aten::add#34572

[quant][graphmode] quantization support for aten::add#34572
jerryzh168 wants to merge 27 commits intogh/jerryzh168/247/basefrom
gh/jerryzh168/247/head

jerryzh168 commented Mar 11, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Mar 11, 2020 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jerryzh168 commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

Uh oh!

facebook-github-bot commented Mar 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerryzh168 commented Mar 11, 2020 •

edited

Loading

dr-ci Bot commented Mar 11, 2020 •

edited

Loading