Skip to content

[quant][graphmode] Add quantization support for aten::dropout#34347

Closed
jerryzh168 wants to merge 15 commits intogh/jerryzh168/239/basefrom
gh/jerryzh168/239/head
Closed

[quant][graphmode] Add quantization support for aten::dropout#34347
jerryzh168 wants to merge 15 commits intogh/jerryzh168/239/basefrom
gh/jerryzh168/239/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Mar 6, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D20504453

@jerryzh168
[quant][graphmode] Add quantization support for aten::dropout
45c09e5 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner March 6, 2020 02:32
This was referenced Mar 6, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 6, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 6, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit f163e10 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

❄️ 1 tentatively flaky failure

1 failure tentatively classified as flaky but have not triggered reruns to confirm:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_build (1/1)

Step: "Build" (full log | pattern match details) ❄️

Error generating file 
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2144: syntax error: 'unknown-type' should be preceded by ')'
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2144: syntax error: 'unknown-type' should be preceded by ';'
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2238: unexpected token(s) preceding ';'
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2059: syntax error: ')'
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2988: unrecognizable template declaration/definition
C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/include\thrust/system/cuda/detail/core/util.h(291): error C2059: syntax error: '<end Parse>'
-- Removing C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_DistanceKernel.cu.obj
C:/Jenkins/Miniconda3/Library/bin/cmake.exe -E remove C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_DistanceKernel.cu.obj
CMake Error at torch_cuda_generated_DistanceKernel.cu.obj.Release.cmake:281 (message):
  Error generating file
  C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_DistanceKernel.cu.obj


 generated_file:STRING=C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_CompareNEKernel.cu.obj -D generated_cubin_file:STRING=C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_CompareNEKernel.cu.obj.cubin.txt -P C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/torch_cuda_generated_CompareNEKernel.cu.obj.Release.cmake" 
-- Removing C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_CompareNEKernel.cu.obj
C:/Jenkins/Miniconda3/Library/bin/cmake.exe -E remove C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_CompareNEKernel.cu.obj
-- Generating dependency file: C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/torch_cuda_generated_CompareNEKernel.cu.obj.NVCC-depend
c -IC:/Users/circleci/project/aten/../third_party/catch/single_include -IC:/Users/circleci/project/aten/src/ATen/.. -IC:/Users/circleci/project/build/caffe2/aten/src/ATen -IC:/Users/circleci/project/c10/cuda/../.. -IC:/Users/circleci/project/c10/../ -IC:/Users/circleci/project/caffe2/../torch/csrc/api -IC:/Users/circleci/project/caffe2/../torch/csrc/api/include -IC:/Users/circleci/project/build/third_party/ideep/mkl-dnn/include -IC:/Users/circleci/project/third_party/ideep/mkl-dnn/src/../include
CompareNEKernel.cu 
-- Generating temporary cmake readable file: C:/Users/circleci/project/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/torch_cuda_generated_CompareNEKernel.cu.obj.depend.tmp
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 81 times.

@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
5e4a56b 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Mar 7, 2020
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
4ed4541 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Mar 7, 2020
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
6ad0495 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Mar 10, 2020
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
6e3b9e4 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
f7ea1b0 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Mar 11, 2020
Closed
@jerryzh168 jerryzh168 mentioned this pull request Mar 11, 2020
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
a7e8a59 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
63ef32d 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
692a661 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Mar 16, 2020
Closed
Closed
Closed
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
f7a9f6d 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Mar 17, 2020
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
de39606 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
bf33e81 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
e729cea 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
38eeb8d 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20504453](https://our.internmc.facebook.com/intern/diff/D20504453)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::drop…
f163e10 
…out"

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20504453](https://our.internmc.facebook.com/intern/diff/D20504453)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 18, 2020

This pull request has been merged in d77d907.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/239/head branch March 22, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Add quantization support for aten::dropout (pytorc…
e7b467f 
…h#34347)

Summary: Pull Request resolved: pytorch#34347

Test Plan:
python test/test_jit.py

Imported from OSS

Differential Revision: D20504453

fbshipit-source-id: 1bab29e21d0564ed88cdeb4894addfe00ebbd390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @raghuramank100 @mruberry