Skip to content

feat(oxfmt): Format parser:json files by oxc_formatter_json#22709

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json
May 29, 2026
Merged

feat(oxfmt): Format parser:json files by oxc_formatter_json#22709
graphite-app[bot] merged 1 commit into
mainfrom
05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json

Conversation

@leaysgur

@leaysgur leaysgur commented May 25, 2026

Copy link
Copy Markdown
Member

Use oxc_formatter_json for major .json files, originally formatted by Prettier.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels May 25, 2026

leaysgur commented May 25, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@codspeed-hq

codspeed-hq Bot commented May 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks


Comparing 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json (3d35ec3) with 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json (3d3c823)1

Open in CodSpeed

Footnotes

  1. No successful run was found on 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json (f660c95) during the generation of this report, so 18a8d7b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 3455de6 to 5851485 Compare May 25, 2026 07:49
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from fbd7d62 to 0e10ae2 Compare May 25, 2026 07:49
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 5851485 to 4c61c6e Compare May 25, 2026 07:50
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 0e10ae2 to 274376b Compare May 25, 2026 07:50
@leaysgur

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 274376b to a03b6d8 Compare May 25, 2026 08:06
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch 2 times, most recently from ced0298 to b9e127b Compare May 25, 2026 08:35
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from a03b6d8 to a2da9c2 Compare May 25, 2026 08:35
@leaysgur

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from b9e127b to f55e574 Compare May 25, 2026 09:17
@leaysgur

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 8c1fe42 to 6b9d0af Compare May 25, 2026 11:25
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from f55e574 to 11ff467 Compare May 25, 2026 11:25
@leaysgur

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@leaysgur

Copy link
Copy Markdown
Member Author
# BEFORE
❯ ./node_modules/.bin/oxfmt '**/*.json' --check
Checking formatting...

All matched files use the correct format.
Finished in 1788ms on 1094 files using 8 threads.

# AFTER
❯ node ~/Codes/oxc/apps/oxfmt/dist/cli.js '**/*.json' --check
Checking formatting...

All matched files use the correct format.
Finished in 436ms on 1094 files using 8 threads.

Looks good?

@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 05bcdd3 to b901c06 Compare May 28, 2026 00:44
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch 2 times, most recently from e60c2cf to ddcfca5 Compare May 28, 2026 02:33
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch 2 times, most recently from 2b2dce1 to c2b7046 Compare May 28, 2026 06:46
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from ddcfca5 to 0d97724 Compare May 28, 2026 06:46
@leaysgur

Copy link
Copy Markdown
Member Author

/oxfmt-ecosys

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest refs/pull/22709/head branch
cnpm/cnpmcore
AmanVarshney01/create-better-t-stack
eggjs/egg
monkeytypegame/monkeytype
huggingface/huggingface.js
actualbudget/actual
formatjs/formatjs
fastify/fastify-vite
dyad-sh/dyad
fuma-nama/fumadocs
lichess-org/lila
vercel/turborepo
vuejs/core
mastodon/mastodon
vuejs/pinia
getsentry/sentry-javascript
cloudflare/agents
rolldown/rolldown
tale/headplane
openclaw/openclaw
npmx-dev/npmx.dev
aidenybai/react-grab
Comfy-Org/ComfyUI_frontend

@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 0d97724 to 6816b91 Compare May 28, 2026 07:14
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from c2b7046 to 6366e00 Compare May 28, 2026 07:14
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 6816b91 to 3d3c823 Compare May 28, 2026 07:29
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 1cd07bd to 5735c08 Compare May 28, 2026 07:29
@leaysgur leaysgur force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from 3d3c823 to f660c95 Compare May 29, 2026 00:27
@leaysgur leaysgur force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 5735c08 to 3d35ec3 Compare May 29, 2026 00:27
@leaysgur leaysgur marked this pull request as ready for review May 29, 2026 00:48
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label May 29, 2026

leaysgur commented May 29, 2026

Copy link
Copy Markdown
Member Author

Merge activity

Use `oxc_formatter_json` for major `.json` files, originally formatted by Prettier.
@graphite-app graphite-app Bot force-pushed the 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json branch from f660c95 to e4a89ec Compare May 29, 2026 00:51
@graphite-app graphite-app Bot force-pushed the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch from 3d35ec3 to d75cbbf Compare May 29, 2026 00:52
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 29, 2026
Base automatically changed from 05-22-refactor_formatter_share_fixtures_test_harness_and_test_formatter_json to main May 29, 2026 00:59
@graphite-app graphite-app Bot merged commit d75cbbf into main May 29, 2026
32 checks passed
@graphite-app graphite-app Bot deleted the 05-25-feat_oxfmt_format_parser_json_files_by_oxc_formatter_json branch May 29, 2026 01:00
camc314 pushed a commit that referenced this pull request Jun 1, 2026
# Oxlint
### 🚀 Features

- e4b1f46 linter/typescript: Implement `method-signature-style` rule
(#22679) (Mikhail Baev)
- bc462ca linter/vue: Implement no-reserved-component-names rule
(#22741) (bab)
- ef9e751 linter/vue: Implement component-definition-name-casing rule
(#22818) (bab)
- d67f51a linter/vue: Implement require-prop-type-constructor rule
(#22708) (bab)
- 1444f82 linter/promise/spec-only: Add `Promise.try` to `Promise`
static methods (#22812) (Ben Saufley)
- 8422e8b linter/jsdoc: Implement `require-yields-description` rule
(#22805) (Mikhail Baev)
- fe93f97 linter/eslint: Implement `prefer-named-capture-group` rule
(#22759) (Sebastian Poxhofer)
- 1a7798b linter: Add suggestion for `unicorn/no-new-array` (#22682)
(Sysix)

### 🐛 Bug Fixes

- 760a9f9 linter: Report errors when writing to the filesystem (#22881)
(camc314)
- e5a2748 linter: Avoid no-unreachable false positive after conditional
loop (#22869) (camc314)
- 39d92d6 linter/arrow-body-style: Preserve comments within function
(#22854) (Sysix)
- 3d13e29 parser: Reject `declare` in an already-ambient context
(TS1038) (#22850) (Boshen)
- 5152854 parser: Reject statements in ambient contexts (TS1036)
(#22849) (Boshen)
- 2eafea6 parser: Reject function implementations in ambient contexts
(TS1183) (#22845) (Boshen)
- c645615 parser: Reject incompatible class member modifiers (#22843)
(Boshen)
- 4a1ca4a linter/export: Detect duplicate explicit exports (#22798)
(camc314)
- 0a9a735 linter/no-loop-func: Allow safe let closures (#22811)
(camc314)
- 1599f11 linter: Align lsp extends default plugins (#22788) (camc314)
- db32ec9 linter/no-accumulating-spread: Use loop as primary span
(#22800) (camc314)
- 33ec6b4 linter/consistent-test-it: Avoid adjacent describe leakage
(#22796) (camc314)
- 2606069 linter/no-array-sort: Unwrap parenthesized sort args (#22794)
(camc314)
- 9f2f709 linter/no-array-sort: Skip non compare fn sort arguments
(#22752) (Gaurav Dubey)
- 27268a0 linter/no-else-return: Preserve statement boundary in fixer
(#22687) (camc314)
- d9cb6d8 linter/no-empty-function: Allow functions callbacks with
`allow: functions` (#22764) (camc314)
- a40a314 linter/no-shadow-restricted-names: Ignore enum members
(#22762) (camc314)
- 82366d9 linter/no-cond-assign: Align ternary handling (#22761)
(camc314)

### 📚 Documentation

- 5e113ba linter: Add license notices for ported ESLint plugins (#22768)
(Boshen)
# Oxfmt
### 🚀 Features

- d75cbbf oxfmt: Format `parser:json` files by `oxc_formatter_json`
(#22709) (leaysgur)
- 49db054 formatter_json: Implement `oxc_formatter_json` (json variant
only) (#22641) (leaysgur)
- 9c71f2e ast, codegen, formatter: Add `WithClauseKeyword::as_str`
helper and use it (#22791) (camc314)

### 🐛 Bug Fixes

- d3cdd62 oxfmt: Skip formatting for whitespace-only file (#22780)
(leaysgur)
- 23f0cc8 formatter: Don't move comments inside variable declaration in
for in loop (#22776) (leaysgur)
- f200c40 formatter: Don't move comments inside variable declaration in
for of loop (#22773) (Leonabcd123)

### 📚 Documentation

- 845f393 oxfmt,formatter,formatter_json,formatter_core: Add/update
AGENTS.md (#22873) (leaysgur)
@leaysgur leaysgur mentioned this pull request Jun 8, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant