refactor(formatter): Split oxc_formatter and oxc_formatter_core#22611
Merged
graphite-app[bot] merged 1 commit intoMay 29, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing 
|
0740a07 to
7acaff3
Compare
oxc_formatter and oxc_formatter_core
This was referenced May 20, 2026
efa1e46 to
6cdd132
Compare
fd0a1f5 to
edff188
Compare
f478d9f to
838c1c2
Compare
dbfdc50 to
15bef1e
Compare
Contributor
Merge activity
|
…22611) Split `oxc_formatter` into: - `oxc_formatter(_js)`: JS/TS specific formatter, comment handling, sortImports, jsdoc, etc - `oxc_formatter_core`: Language agnostic IR, printer, etc The naming convention is different from Biome or Ruff (they do not have `_core`, and `_formatter` is equivalent to the core), but this is because in Oxc, items without `_js` are the default. As a basic task, I have added `Context` as a generic to all relevant parts to ensure support for multiple languages. There might still be other components that could be refactored into the core, but I would like to finish them as I implement support for other languages. Also moved some shared utilities to the core in advance.
15bef1e to
c323187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
oxc_formatterinto:oxc_formatter(_js): JS/TS specific formatter, comment handling, sortImports, jsdoc, etcoxc_formatter_core: Language agnostic IR, printer, etcThe naming convention is different from Biome or Ruff (they do not have
_core, and_formatteris equivalent to the core), but this is because in Oxc, items without_jsare the default.As a basic task, I have added
Contextas a generic to all relevant parts to ensure support for multiple languages.There might still be other components that could be refactored into the core, but I would like to finish them as I implement support for other languages.
Also moved some shared utilities to the core in advance.