Skip to content

ci(tasks/conformance): Add json prettier conformance#22670

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-22-tasks_conformance_add_json_prettier_conformance
May 29, 2026
Merged

ci(tasks/conformance): Add json prettier conformance#22670
graphite-app[bot] merged 1 commit into
mainfrom
05-22-tasks_conformance_add_json_prettier_conformance

Conversation

@leaysgur

@leaysgur leaysgur commented May 22, 2026

Copy link
Copy Markdown
Member

json compatibility: 20/20 (100.00%)

🎉 (..., I know that Prettier's conformance isn't exactly reliable.)

Anyway, I'm also thinking about refactoring the conformance mechanism itself. 🤔

leaysgur commented May 22, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented May 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks


Comparing 05-22-tasks_conformance_add_json_prettier_conformance (39fdc17) with 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ (4bff424)

Open in CodSpeed

@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from eb658cf to 5724334 Compare May 22, 2026 03:50
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 5ead9f2 to 4f6a686 Compare May 22, 2026 03:50
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 5724334 to f17381b Compare May 22, 2026 04:11
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 4f6a686 to e0ce119 Compare May 22, 2026 04:11
@leaysgur leaysgur changed the title tasks(conformance): Add json prettier conformance ci(tasks/conformance): Add json prettier conformance May 22, 2026
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from e0ce119 to 1ca0d08 Compare May 22, 2026 04:18
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from f17381b to e297be2 Compare May 22, 2026 06:39
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch 2 times, most recently from 608f38a to be90eb3 Compare May 22, 2026 08:12
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from e297be2 to 1d61bc2 Compare May 22, 2026 08:12
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from f9561dd to d02ce5d Compare May 22, 2026 08:14
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch 2 times, most recently from 6b2a53d to 67e4127 Compare May 25, 2026 00:38
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch 2 times, most recently from 3f98531 to de2a7f4 Compare May 25, 2026 02:10
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 67e4127 to cd27ff4 Compare May 25, 2026 02:10
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from de2a7f4 to 87de790 Compare May 25, 2026 02:20
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch 2 times, most recently from ac201c9 to 008f5cc Compare May 25, 2026 05:51
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 87de790 to 3385f17 Compare May 25, 2026 05:51
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 3385f17 to ebbcfe6 Compare May 25, 2026 07:49
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch 2 times, most recently from 4d4f037 to 521be5d Compare May 25, 2026 07:50
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 870e92f to b918c86 Compare May 25, 2026 11:25
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 2108902 to 674f56f Compare May 25, 2026 11:25
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from b918c86 to b3d5bbb Compare May 26, 2026 06:24
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 674f56f to 9cbe86d Compare May 26, 2026 06:24
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from b3d5bbb to 7f3657c Compare May 26, 2026 08:21
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 9cbe86d to 1d9ec03 Compare May 26, 2026 08:21
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 7f3657c to 533b669 Compare May 28, 2026 00:44
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 1d9ec03 to 12d19d1 Compare May 28, 2026 00:44
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 533b669 to 91950d8 Compare May 28, 2026 02:33
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch 2 times, most recently from 8923568 to 5371b7b Compare May 28, 2026 06:46
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch 2 times, most recently from 926566f to 3d03754 Compare May 28, 2026 07:14
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch 2 times, most recently from de845b0 to a02c1d6 Compare May 28, 2026 07:29
@leaysgur leaysgur force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch 2 times, most recently from 792ee0a to 4bff424 Compare May 29, 2026 00:27
@leaysgur leaysgur force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from a02c1d6 to 39fdc17 Compare May 29, 2026 00:27
@leaysgur leaysgur marked this pull request as ready for review May 29, 2026 00:48
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label May 29, 2026
@graphite-app

graphite-app Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Merge activity

> json compatibility: 20/20 (100.00%)

🎉  (..., I know that Prettier's conformance isn't exactly reliable.)

Anyway, I'm also thinking about refactoring the conformance mechanism itself. 🤔
@graphite-app graphite-app Bot force-pushed the 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ branch from 4bff424 to 49db054 Compare May 29, 2026 00:50
@graphite-app graphite-app Bot force-pushed the 05-22-tasks_conformance_add_json_prettier_conformance branch from 39fdc17 to e12e1fc Compare May 29, 2026 00:51
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 29, 2026
Base automatically changed from 05-21-feat_formatter_json_implement_oxc_formatter_json_json_variant_only_ to main May 29, 2026 00:57
@graphite-app graphite-app Bot merged commit e12e1fc into main May 29, 2026
32 checks passed
@graphite-app graphite-app Bot deleted the 05-22-tasks_conformance_add_json_prettier_conformance branch May 29, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant