Skip to content

fix(transformer): use SPAN for synthesized helper calls to prevent comment misattribution#21578

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix/transformer-helper-call-span-fix
Apr 22, 2026
Merged

fix(transformer): use SPAN for synthesized helper calls to prevent comment misattribution#21578
graphite-app[bot] merged 1 commit intomainfrom
fix/transformer-helper-call-span-fix

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Apr 20, 2026

Fixes https://github.com/oxc-project/monitor-oxc/actions/runs/24666844194/job/72126949181

Summary

Helper calls like _defineProperty and _classPrivateFieldSet2 were using the original expression's span. Codegen's print_arguments checks span.end - 1 for comments before the closing paren — when the original span's end coincided with a comment's attached_to position, codegen would incorrectly switch to multi-line formatting, breaking idempotency.

Use SPAN (zero span) for synthesized calls since they have no original source position. This is consistent with how TypeScript (pos=-1), SWC (DUMMY_SP), and esbuild handle generated nodes.

No sourcemap impact — codegen already skips source mapping for empty spans (!span.is_empty() guard). The arguments inside the call still have their own valid spans and map correctly.

Test plan

  • Added helper_call_idempotency test: transform class with comments inside property values → verify codegen is idempotent
  • cargo test -p oxc_transformer — all pass
  • cargo run -p oxc_transform_conformance — no snapshot changes

Copy link
Copy Markdown
Member Author

Dunqing commented Apr 20, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing fix/transformer-helper-call-span-fix (ebec0b3) with main (510e344)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the fix/transformer-helper-call-span-fix branch from 7bc49d6 to ebec0b3 Compare April 20, 2026 14:48
@Dunqing Dunqing marked this pull request as ready for review April 20, 2026 15:59
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 20, 2026 15:59
@Dunqing Dunqing marked this pull request as draft April 21, 2026 08:19
@Dunqing Dunqing marked this pull request as ready for review April 22, 2026 08:49
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Apr 22, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 22, 2026

Merge activity

…mment misattribution (#21578)

Fixes https://github.com/oxc-project/monitor-oxc/actions/runs/24666844194/job/72126949181
## Summary

Helper calls like `_defineProperty` and `_classPrivateFieldSet2` were using the original expression's span. Codegen's `print_arguments` checks `span.end - 1` for comments before the closing paren — when the original span's end coincided with a comment's `attached_to` position, codegen would incorrectly switch to multi-line formatting, breaking idempotency.

Use `SPAN` (zero span) for synthesized calls since they have no original source position. This is consistent with how TypeScript (`pos=-1`), SWC (`DUMMY_SP`), and esbuild handle generated nodes.

No sourcemap impact — codegen already skips source mapping for empty spans (`!span.is_empty()` guard). The arguments inside the call still have their own valid spans and map correctly.

## Test plan

- Added `helper_call_idempotency` test: transform class with comments inside property values → verify codegen is idempotent
- `cargo test -p oxc_transformer` — all pass
- `cargo run -p oxc_transform_conformance` — no snapshot changes
@graphite-app graphite-app Bot force-pushed the fix/transformer-helper-call-span-fix branch from ebec0b3 to c92bd3b Compare April 22, 2026 09:32
@graphite-app graphite-app Bot merged commit c92bd3b into main Apr 22, 2026
27 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 22, 2026
@graphite-app graphite-app Bot deleted the fix/transformer-helper-call-span-fix branch April 22, 2026 09:43
graphite-app Bot pushed a commit that referenced this pull request Apr 22, 2026
…helper_call_expr (#21579)

## Summary

Follow-up to #21578. Since helper calls now always use `SPAN`, the `span` parameter is unnecessary. This removes it from `helper_call` and `helper_call_expr` and cleans up all 28 call sites across 12 files.

Also removes now-unused `span` parameters from internal functions that only existed to pass through to helper calls:
- `create_private_field_get`
- `create_private_field_set`
- `create_check_in_rhs`
- `create_private_instance_init_assignment_not_loose`

## Test plan

- `cargo build -p oxc_transformer` — no warnings (except pre-existing `oxc_allocator`)
- `cargo test -p oxc_transformer` — all pass
- `cargo run -p oxc_transform_conformance` — no snapshot changes
camc314 pushed a commit that referenced this pull request Apr 27, 2026
### 💥 BREAKING CHANGES

- 502e804 ast: [**BREAKING**] Reduce size of `TSTypePredicateName`
(#21711) (overlookmotel)
- 5651539 ast: [**BREAKING**] Reduce size of `JSXExpression` (#21710)
(overlookmotel)
- c44e280 ast: [**BREAKING**] Reduce size of `ArrayExpressionElement`
(#21709) (overlookmotel)
- c5b3deb syntax: [**BREAKING**] Remove `CommentNodeId` (#21679)
(overlookmotel)

### 🚀 Features

- b738a39 allocator: Add `Allocator::cursor_ptr` method (#21773)
(overlookmotel)
- 678767e ast: Generate node_id accessors for AST enum wrappers (#21653)
(camc314)
- f091d77 minifier: Inline constant spread elements into arrays (#21095)
(Armano)

### 🐛 Bug Fixes

- 0d608c2 minifier: Preserve raw CR in template literals (#21645)
(Dunqing)
- a889ea9 minifier: Track pure functions in DCE mode (#21722) (Dunqing)
- 674dfac allocator: `Arena` retry allocation when chunk size approaches
maximum (#21777) (overlookmotel)
- f130cc0 allocator: Fix arithmetic overflow in
`Arena::new_chunk_memory_details` (#21745) (overlookmotel)
- b9bf239 allocator: Fix UB in `Arena::grow_zeroed` (#21739)
(overlookmotel)
- d2b9389 allocator: Clippy warning when building without `testing`
feature (#21681) (camc314)
- 503dc86 codegen: Map sourcemaps from visible output starts (#21662)
(Dunqing)
- c92bd3b transformer: Use SPAN for synthesized helper calls to prevent
comment misattribution (#21578) (Dunqing)
- 0d80441 codegen: Add mapping before printing `#` for private ident
(#21619) (camc314)

### ⚡ Performance

- 9fa362e napi/parser: Do not generate tokens except in tests (#21811)
(overlookmotel)
- 0044392 allocator: Reduce branches when allocating new chunk (#21776)
(overlookmotel)
- 7896bd0 allocator: `Allocator::used_bytes` do not use chunk iterator
(#21771) (overlookmotel)
- a5c562f allocator: Remove check in `Arena::new_chunk_memory_details`
(#21750) (overlookmotel)
- 35bbe1f allocator: `Arena` use unchecked size round up where
guaranteed no overflow (#21743) (overlookmotel)
- ffe229b allocator: Remove unnecessary check from
`Arena::try_alloc_layout_slow_impl` (#21732) (overlookmotel)
- 72fece5 allocator: Use `NonNull::offset_from_unsigned` in
`Arena::chunk_capacity` (#21731) (overlookmotel)
- cab32ae ast: Add `#[inline(always)]` to `node_id` methods on enums
with all variants unboxed (#21707) (overlookmotel)
- b179688 parser: Allocate `TriviaBuilder` comments in the arena
(#21512) (Boshen)
- 2290f31 lexer: Fix perf of `Token::set_*` methods on Rust 1.95.0
(#21659) (overlookmotel)
- 1b58029 allocator: Move code into cold path in `Arena::alloc_layout`
(#21622) (overlookmotel)
- 3cf7cef allocator: Reduce instructions on allocation hot path (#21510)
(overlookmotel)

### 📚 Documentation

- ce65070 data_structures: Document why `as_ref` and `as_mut` on
`NonNullConst` and `NonNullMut` take `self` (#21800) (overlookmotel)
- 93b7dbd allocator: Improve doc comments for `ChunkFooter` (#21733)
(overlookmotel)
- 295db8d transformer: Fix comment (#21717) (overlookmotel)
- 5c93af8 ast: Add comments explaining `#[inline(always)]` to `node_id`
methods on enums (#21706) (overlookmotel)
- e4cea25 transform: Use the `node:` namespace in the example (#19998)
(루밀LuMir)

### 🛡️ Security

- d8076c9 deps: Update rolldown (#21639) (renovate)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant