Skip to content

feat(minifier): inline constant spread elements into arrays#21095

Merged
sapphi-red merged 14 commits intooxc-project:mainfrom
armano2:feat/minifier-inline-spread-into-arrays
Apr 23, 2026
Merged

feat(minifier): inline constant spread elements into arrays#21095
sapphi-red merged 14 commits intooxc-project:mainfrom
armano2:feat/minifier-inline-spread-into-arrays

Conversation

@armano2
Copy link
Copy Markdown
Contributor

@armano2 armano2 commented Apr 6, 2026

implements flattening logic used to inline constant spread elements into arrays

fixes #17358

@github-actions github-actions Bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Apr 6, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 6, 2026

Merging this PR will not alter performance

✅ 40 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing armano2:feat/minifier-inline-spread-into-arrays (b52e618) with main (5df2eb4)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@armano2

This comment was marked as off-topic.

@sapphi-red
Copy link
Copy Markdown
Member

I'm not sure about the reason but probably not directly related to this PR. It seems to be failing on main for a while now.

Comment thread crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
@camc314
Copy link
Copy Markdown
Contributor

camc314 commented Apr 7, 2026

@ sapphi-red any idea why https://github.com/oxc-project/oxc/actions/runs/24085231649/job/70256169735?pr=21095 seem to be panicking on ci

cargo +nightly doc --no-deps --document-private-items -Zrustdoc-mergeable-info

   Merging 52 docs for host
    Finished documentation merge in 1.75s
   Generated /home/dev/oxc/target/doc/oxc/index.html and 51 other files

rust-lang/rust#154818

Comment thread crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
Comment thread crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
…elisions

Signed-off-by: 翠 <green@sapphi.red>
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red merged commit f091d77 into oxc-project:main Apr 23, 2026
33 of 34 checks passed
@armano2 armano2 deleted the feat/minifier-inline-spread-into-arrays branch April 23, 2026 14:46
camc314 pushed a commit that referenced this pull request Apr 27, 2026
### 💥 BREAKING CHANGES

- 502e804 ast: [**BREAKING**] Reduce size of `TSTypePredicateName`
(#21711) (overlookmotel)
- 5651539 ast: [**BREAKING**] Reduce size of `JSXExpression` (#21710)
(overlookmotel)
- c44e280 ast: [**BREAKING**] Reduce size of `ArrayExpressionElement`
(#21709) (overlookmotel)
- c5b3deb syntax: [**BREAKING**] Remove `CommentNodeId` (#21679)
(overlookmotel)

### 🚀 Features

- b738a39 allocator: Add `Allocator::cursor_ptr` method (#21773)
(overlookmotel)
- 678767e ast: Generate node_id accessors for AST enum wrappers (#21653)
(camc314)
- f091d77 minifier: Inline constant spread elements into arrays (#21095)
(Armano)

### 🐛 Bug Fixes

- 0d608c2 minifier: Preserve raw CR in template literals (#21645)
(Dunqing)
- a889ea9 minifier: Track pure functions in DCE mode (#21722) (Dunqing)
- 674dfac allocator: `Arena` retry allocation when chunk size approaches
maximum (#21777) (overlookmotel)
- f130cc0 allocator: Fix arithmetic overflow in
`Arena::new_chunk_memory_details` (#21745) (overlookmotel)
- b9bf239 allocator: Fix UB in `Arena::grow_zeroed` (#21739)
(overlookmotel)
- d2b9389 allocator: Clippy warning when building without `testing`
feature (#21681) (camc314)
- 503dc86 codegen: Map sourcemaps from visible output starts (#21662)
(Dunqing)
- c92bd3b transformer: Use SPAN for synthesized helper calls to prevent
comment misattribution (#21578) (Dunqing)
- 0d80441 codegen: Add mapping before printing `#` for private ident
(#21619) (camc314)

### ⚡ Performance

- 9fa362e napi/parser: Do not generate tokens except in tests (#21811)
(overlookmotel)
- 0044392 allocator: Reduce branches when allocating new chunk (#21776)
(overlookmotel)
- 7896bd0 allocator: `Allocator::used_bytes` do not use chunk iterator
(#21771) (overlookmotel)
- a5c562f allocator: Remove check in `Arena::new_chunk_memory_details`
(#21750) (overlookmotel)
- 35bbe1f allocator: `Arena` use unchecked size round up where
guaranteed no overflow (#21743) (overlookmotel)
- ffe229b allocator: Remove unnecessary check from
`Arena::try_alloc_layout_slow_impl` (#21732) (overlookmotel)
- 72fece5 allocator: Use `NonNull::offset_from_unsigned` in
`Arena::chunk_capacity` (#21731) (overlookmotel)
- cab32ae ast: Add `#[inline(always)]` to `node_id` methods on enums
with all variants unboxed (#21707) (overlookmotel)
- b179688 parser: Allocate `TriviaBuilder` comments in the arena
(#21512) (Boshen)
- 2290f31 lexer: Fix perf of `Token::set_*` methods on Rust 1.95.0
(#21659) (overlookmotel)
- 1b58029 allocator: Move code into cold path in `Arena::alloc_layout`
(#21622) (overlookmotel)
- 3cf7cef allocator: Reduce instructions on allocation hot path (#21510)
(overlookmotel)

### 📚 Documentation

- ce65070 data_structures: Document why `as_ref` and `as_mut` on
`NonNullConst` and `NonNullMut` take `self` (#21800) (overlookmotel)
- 93b7dbd allocator: Improve doc comments for `ChunkFooter` (#21733)
(overlookmotel)
- 295db8d transformer: Fix comment (#21717) (overlookmotel)
- 5c93af8 ast: Add comments explaining `#[inline(always)]` to `node_id`
methods on enums (#21706) (overlookmotel)
- e4cea25 transform: Use the `node:` namespace in the example (#19998)
(루밀LuMir)

### 🛡️ Security

- d8076c9 deps: Update rolldown (#21639) (renovate)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: inline constant spread elements into arrays

3 participants