Merge engine-q into Nushell (second try)#4364
Merged
Conversation
* Allow for and other commands missing positionals near keywords * A bit more resilience
* update to the latest reedline * update to latest reedline
* revert file_types to lowercase * fix test
Signed-off-by: nibon7 <nibon7@163.com>
* get_columns is working in the columns command * the new location of the get_columns method is nu-protocol/src/column.rs * reference the new location of the get_columns method * move get_columns to nu-engine
* port over from nushell the column flag for the length command * fix clippy error * refactor with the get_columns now centrally located
* make prompt indicators configurable * seems to be working now
* Add fuzzy/ignore flag to get * Handle plugins before config
* Allow pipelines across multiple lines if end in pipe * Add validation support
* Fix build breakage - bump ansi term * Remove e-q ansi term
* Fix list printing * Fix list and table highlighting
* Add `error make` and improve `metadata` * Allow metadata to work on just a pipeline
* renamed some files * clippy * update tests
* reedline bump * reedline bump * reedline bump
nightscape
reviewed
Feb 8, 2022
drbrain
added a commit
to drbrain/nushell
that referenced
this pull request
Nov 21, 2023
I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though.
WindSoilder
pushed a commit
that referenced
this pull request
Nov 21, 2023
# Description `ShellError::FlagNotFound` had a note that said it may be removable so this PR removes it instead of updating it to named fields per #10700 I can't see this error being used since it was introduced with #4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
drbrain
added a commit
to drbrain/nushell
that referenced
this pull request
Dec 9, 2023
These were added in nushell#4364 and were no longer used with nushell#4387
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description `ShellError::FlagNotFound` had a note that said it may be removable so this PR removes it instead of updating it to named fields per nushell#10700 I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description `ShellError::FlagNotFound` had a note that said it may be removable so this PR removes it instead of updating it to named fields per nushell#10700 I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.