Skip to content

Building akin to azure-pipelines to shorten CircleCI builds#622

Merged
sophiajt merged 1 commit intonushell:masterfrom
vsoch:test/shorter-docker-builds
Sep 8, 2019
Merged

Building akin to azure-pipelines to shorten CircleCI builds#622
sophiajt merged 1 commit intonushell:masterfrom
vsoch:test/shorter-docker-builds

Conversation

@vsoch
Copy link
Copy Markdown
Contributor

@vsoch vsoch commented Sep 8, 2019

This is a work in progress to test building on CircleCI (in debug, meaning we remove the --release tag) to see if the build times are shorter. Changes include:

  • I've removed the rust library base image in favor of the same base used in azure (ubuntu:16.04) to try and replicate to the best that we can.
  • The command to install rust is also taken from azure-pipelines, targeting a specific nightly build
  • To control building release / debug, there is a RELEASE build arg. We only add it in the case of a tag/release, otherwise we build debug.

My wireless is out today so I've been developing on a remote instance, which isn't as great as local (so it's a bit slow). I figure it would be quicker / more reproducing of the actual build environment to open the PR and use CircleCI to test the timing. I'm testing a build (with release) on my instance, and we can test the debug build here.

I'm also:

  • removing extra dependencies that @jonathandturner mentioned aren't needed
  • removing the need for the QUAY_TOKEN in favor of the defaults, and the function to check

And of course, I'll update the PR if needed.

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

@vsoch vsoch changed the title [WIP] building akin to azure-pipelines to shorten CircleCI builds Building akin to azure-pipelines to shorten CircleCI builds Sep 8, 2019
@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 8, 2019

Removing the WIP flag - this is ready for review, per the standard of code review that it will leave the code base in a better state than currently. It would still be ideal to have a cache to install just dependencies, but that will be for another day (I gave it a good shot with https://github.com/nacardin/cargo-build-deps and just copying the Cargo.toml but didn't get it working).

…shorten circleci builds

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 8, 2019

Re-added the dependencies for the extra features. If a user pulls with Singularity, for example, they can easily use x11.

@sophiajt sophiajt merged commit 4ce6a9c into nushell:master Sep 8, 2019
elferherrera pushed a commit to elferherrera/nushell that referenced this pull request Feb 7, 2022
kubouch pushed a commit that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants