Building akin to azure-pipelines to shorten CircleCI builds#622
Merged
sophiajt merged 1 commit intonushell:masterfrom Sep 8, 2019
vsoch:test/shorter-docker-builds
Merged
Building akin to azure-pipelines to shorten CircleCI builds#622sophiajt merged 1 commit intonushell:masterfrom vsoch:test/shorter-docker-builds
sophiajt merged 1 commit intonushell:masterfrom
vsoch:test/shorter-docker-builds
Conversation
Contributor
Author
|
Removing the WIP flag - this is ready for review, per the standard of code review that it will leave the code base in a better state than currently. It would still be ideal to have a cache to install just dependencies, but that will be for another day (I gave it a good shot with https://github.com/nacardin/cargo-build-deps and just copying the Cargo.toml but didn't get it working). |
…shorten circleci builds Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Contributor
Author
|
Re-added the dependencies for the extra features. If a user pulls with Singularity, for example, they can easily use x11. |
elferherrera
pushed a commit
to elferherrera/nushell
that referenced
this pull request
Feb 7, 2022
kubouch
pushed a commit
that referenced
this pull request
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress to test building on CircleCI (in debug, meaning we remove the --release tag) to see if the build times are shorter. Changes include:
RELEASEbuild arg. We only add it in the case of a tag/release, otherwise we build debug.My wireless is out today so I've been developing on a remote instance, which isn't as great as local (so it's a bit slow). I figure it would be quicker / more reproducing of the actual build environment to open the PR and use CircleCI to test the timing. I'm testing a build (with release) on my instance, and we can test the debug build here.
I'm also:
And of course, I'll update the PR if needed.
Signed-off-by: Vanessa Sochat vsochat@stanford.edu