@twe4ked Investigated usage of cd - before my latest PR and this is what I understand and implemented. If you do cd - it takes you back to the last working directory, always. if you cd dir/- you cd into the - directory under dir as covered here for filesystem shell. and here for value shell.

All cases are already covered before this PR. Are we missing something?

The new case that I added. The implementation on master will change to last_dir if you cd -, even if there is a directory named - in the current directory.

Copy the new test case into master for an example.

It's this case from the original test. It wasn't very clear because it was all one big test.

@twe4ked This is what I'm assuming default behavior should be, meaning that if in your working directory there is a directory named - and you do cd -, it still takes you to the last working directory and not cd into -. (This is the same behavior If I try it on macOS, for example)

What behavior should we expect from this? @jonathandturner @wycats

Assuming there is a directory named - in current working directory, doing cd - should:

• cd into last working directory or
• cd into -

Oh interesting. I assumed the default behaviour would be to change to the directory. Just confirmed that bash and zsh both change to last directory (as you said). I thought this was a regression. If we decide to keep the behaviour on master let's add a test case so it's more explicit.

Still, sometimes the legacy behaviors is something we don't want.

I would say cd - always takes you to the last working directory, even if there's a directory called -

👍 I'm cool with that. I'll close, we can always re-open if people feel differently.

@twe4ked we will probably take things back to the drawing board (as suggested by @wycats) since cd should be operating at a higher level other than per individual shell type. If you'd like, please open another PR with the test case that ensures it does not cd into a directory - and takes you to last path instead.