Updating nushell/nu base to have proper version of libssl-dev#655
Updating nushell/nu base to have proper version of libssl-dev#655sophiajt merged 1 commit intonushell:masterfrom vsoch:update/docker-base-18.04
Conversation
|
@jonathandturner see our discussion in #646. I'm interested to know about the choice to use ubuntu:16.04 instead of 18.04 - I wanted to copy the build used for azure pipelines to a T, but for this library it seems to install the correct version in the minified image if we target 18.04. I'm sort of at a loss also for why using the same base (16.04) installs different versions of libssl between nushell/nu-base and nushell/nu - does cargo/rust handle any core library installs or updates? The PR here will update the smaller image to have 18.04 (and the correct library) but it also means that the two images have different bases. Let me know your thoughts! Update: we are testing 16.04! |
|
umm no, nushell/nu is not based on ubuntu, its based on rust-slim which itself is based on debian |
|
That is correct, I tested ubuntu:16.04 (for both) on my host and it resulted in the same issue. |
|
Are you sure that you didn't mess up something? I am pretty sure that using the same base image will solve the problem. I just have a problem with ubuntu base images. They are too "fat" for my taste. But that is just my opinion of course. |
|
I shared the recipe that I used in the issue - I guess you missed it? Here it is again (give it a try!) |
|
I'm sorry you don't like the containers. If it's distasteful to you, perhaps you could do a PR to adjust the bases to your liking. |
|
@vsoch OK, I tried it and it works. There is just no reason this should not work. Maybe you have used old nu-base image to generate new nu image? |
|
Yeah that's a good call! Let me update the PR here to verify - since there is a test we will know for sure! Give me a minute! |
|
@jeka as I reported, it does not work: I'm going to change back to what I previously had that passed. |
… for nu Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Original link is dead. Replaced with new URL.

This will address #646 by updating the second base image to 16.04, and also adding a test after the builds in the circle config to ensure it doesn't pass if this error occurs.
Update: note that the PR originally had 18.04 (hence the name of the branch) but likely there was a local build error (it should work) so we are testing 16.04 now.
Signed-off-by: Vanessa Sochat vsochat@stanford.edu