Skip to content

Updating nushell/nu base to have proper version of libssl-dev#655

Merged
sophiajt merged 1 commit intonushell:masterfrom
vsoch:update/docker-base-18.04
Sep 12, 2019
Merged

Updating nushell/nu base to have proper version of libssl-dev#655
sophiajt merged 1 commit intonushell:masterfrom
vsoch:update/docker-base-18.04

Conversation

@vsoch
Copy link
Copy Markdown
Contributor

@vsoch vsoch commented Sep 12, 2019

This will address #646 by updating the second base image to 16.04, and also adding a test after the builds in the circle config to ensure it doesn't pass if this error occurs.

Update: note that the PR originally had 18.04 (hence the name of the branch) but likely there was a local build error (it should work) so we are testing 16.04 now.

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

@jonathandturner see our discussion in #646. I'm interested to know about the choice to use ubuntu:16.04 instead of 18.04 - I wanted to copy the build used for azure pipelines to a T, but for this library it seems to install the correct version in the minified image if we target 18.04. I'm sort of at a loss also for why using the same base (16.04) installs different versions of libssl between nushell/nu-base and nushell/nu - does cargo/rust handle any core library installs or updates? The PR here will update the smaller image to have 18.04 (and the correct library) but it also means that the two images have different bases. Let me know your thoughts!


Update: we are testing 16.04!

@jeka
Copy link
Copy Markdown

jeka commented Sep 12, 2019

umm no, nushell/nu is not based on ubuntu, its based on rust-slim which itself is based on debian

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

That is correct, I tested ubuntu:16.04 (for both) on my host and it resulted in the same issue.

@jeka
Copy link
Copy Markdown

jeka commented Sep 12, 2019

Are you sure that you didn't mess up something? I am pretty sure that using the same base image will solve the problem. I just have a problem with ubuntu base images. They are too "fat" for my taste. But that is just my opinion of course.

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

I shared the recipe that I used in the issue - I guess you missed it? Here it is again (give it a try!)

ARG FROMTAG=latest
FROM quay.io/nushell/nu-base:${FROMTAG} as base
FROM ubuntu:16.04
COPY --from=base /usr/local/bin/nu /usr/local/bin/nu
ENV DEBIAN_FRONTEND noninteractive
RUN apt-get update && apt-get install -y libssl-dev \
    libxcb-composite0-dev \
    pkg-config \
    curl
ENTRYPOINT ["nu"]
CMD ["-l", "info"]

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

I'm sorry you don't like the containers. If it's distasteful to you, perhaps you could do a PR to adjust the bases to your liking.

@jeka
Copy link
Copy Markdown

jeka commented Sep 12, 2019

@vsoch OK, I tried it and it works. There is just no reason this should not work. Maybe you have used old nu-base image to generate new nu image?

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

Yeah that's a good call! Let me update the PR here to verify - since there is a test we will know for sure! Give me a minute!

@vsoch
Copy link
Copy Markdown
Contributor Author

vsoch commented Sep 12, 2019

@jeka as I reported, it does not work:

image

I'm going to change back to what I previously had that passed.

… for nu

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@sophiajt sophiajt merged commit 4dfebae into nushell:master Sep 12, 2019
elferherrera pushed a commit to elferherrera/nushell that referenced this pull request Feb 7, 2022
kubouch pushed a commit that referenced this pull request Feb 7, 2022
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this pull request Jan 27, 2023
Original link is dead. Replaced with new URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants