Remove ShellError::FlagNotFound#11119
Merged
WindSoilder merged 1 commit intonushell:mainfrom Nov 21, 2023
Merged
Conversation
I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though.
WindSoilder
approved these changes
Nov 21, 2023
Contributor
WindSoilder
left a comment
There was a problem hiding this comment.
Thanks! I'm agree with you, let's remove it
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description `ShellError::FlagNotFound` had a note that said it may be removable so this PR removes it instead of updating it to named fields per nushell#10700 I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description `ShellError::FlagNotFound` had a note that said it may be removable so this PR removes it instead of updating it to named fields per nushell#10700 I can't see this error being used since it was introduced with nushell#4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ShellError::FlagNotFoundhad a note that said it may be removable so this PR removes it instead of updating it to named fields per #10700I can't see this error being used since it was introduced with #4364. I can't find why or where it was used before that date, though. There was a large merge with that PR but I can't penetrate the secrets of git to find out where its earlier history went.
User-Facing Changes
None
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
N/A