Skip to content

Fix bug with ls globbing a single directory#608

Merged
sophiajt merged 2 commits intonushell:masterfrom
pmeredit:master
Sep 7, 2019
Merged

Fix bug with ls globbing a single directory#608
sophiajt merged 2 commits intonushell:masterfrom
pmeredit:master

Conversation

@pmeredit
Copy link
Copy Markdown
Contributor

@pmeredit pmeredit commented Sep 7, 2019

Previously, if you ls globbed a single directory you would get:

/home/pmeredit/git/nushell(master)> ls *src*
error: No such file or directory (os error 2)
- shell:1:3
1 | ls *src*
  |    ^^^^^ No such file or directory (os error 2)

Now it works:

/home/pmeredit/git/nushell(master)> ls *src*
━━━━┯━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━┯━━━━━━━━━━┯━━━━━━━━━┯━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━
 #  │ name            │ type      │ readonly │ size    │ accessed     │ modified 
────┼─────────────────┼───────────┼──────────┼─────────┼──────────────┼───────────────
  0 │ src/commands    │ Directory │          │  1.1 KB │ an hour ago  │ an hour ago 
  1 │ src/env         │ Directory │          │   14 B  │ an hour ago  │ a week ago 
  2 │ src/evaluate    │ Directory │          │   36 B  │ an hour ago  │ an hour ago 
  3 │ src/format      │ Directory │          │   88 B  │ an hour ago  │ an hour ago 
  4 │ src/parser      │ Directory │          │  128 B  │ an hour ago  │ an hour ago 
  5 │ src/plugins     │ Directory │          │  166 B  │ an hour ago  │ an hour ago 
  6 │ src/shell       │ Directory │          │  182 B  │ a minute ago │ 2 minutes ago 
  7 │ src/main.rs     │ File      │          │  1.5 KB │ an hour ago  │ 2 weeks ago 
  8 │ src/git.rs      │ File      │          │  527 B  │ an hour ago  │ a week ago 
  9 │ src/env.rs      │ File      │          │   55 B  │ an hour ago  │ a week ago 
 10 │ src/parser.rs   │ File      │          │  1.1 KB │ an hour ago  │ a week ago 
 11 │ src/stream.rs   │ File      │          │  4.3 KB │ an hour ago  │ a week ago 
 12 │ src/traits.rs   │ File      │          │  598 B  │ an hour ago  │ a week ago 
 13 │ src/context.rs  │ File      │          │  4.3 KB │ an hour ago  │ 3 days ago 
 14 │ src/errors.rs   │ File      │          │ 21.1 KB │ an hour ago  │ 3 days ago 
 15 │ src/format.rs   │ File      │          │  480 B  │ an hour ago  │ 3 days ago 
 16 │ src/plugin.rs   │ File      │          │  5.2 KB │ an hour ago  │ 3 days ago 
 17 │ src/shell.rs    │ File      │          │  221 B  │ an hour ago  │ 3 days ago 
 18 │ src/commands.rs │ File      │          │  3.4 KB │ an hour ago  │ 2 days ago 
 19 │ src/cli.rs      │ File      │          │ 19.2 KB │ an hour ago  │ an hour ago 
 20 │ src/data.rs     │ File      │          │  366 B  │ an hour ago  │ an hour ago 
 21 │ src/data        │ Directory │          │  170 B  │ an hour ago  │ an hour ago 
 22 │ src/lib.rs      │ File      │          │  999 B  │ an hour ago  │ an hour ago 
 23 │ src/prelude.rs  │ File      │          │  3.6 KB │ an hour ago  │ an hour ago 
 24 │ src/utils.rs    │ File      │          │ 12.5 KB │ an hour ago  │ an hour ago 
━━━━┷━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━┷━━━━━━━━━━┷━━━━━━━━━┷━━━━━━━━━━━━━━┷━━━━━```

The code was just using the wrong variable :)

@sophiajt
Copy link
Copy Markdown
Contributor

sophiajt commented Sep 7, 2019

Oops, good catch :)

@sophiajt sophiajt merged commit 452f96a into nushell:master Sep 7, 2019
elferherrera pushed a commit to elferherrera/nushell that referenced this pull request Feb 7, 2022
* update to the latest reedline

* update to latest reedline
kubouch pushed a commit that referenced this pull request Feb 7, 2022
* update to the latest reedline

* update to latest reedline
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants