Skip to content

Expand pwd command#614

Merged
andrasio merged 2 commits intonushell:masterfrom
JonnyWalker81:expand-pwd-command
Sep 7, 2019
Merged

Expand pwd command#614
andrasio merged 2 commits intonushell:masterfrom
JonnyWalker81:expand-pwd-command

Conversation

@JonnyWalker81
Copy link
Copy Markdown
Contributor

@JonnyWalker81 JonnyWalker81 commented Sep 7, 2019

Expand functionality of the pwd command to better handle the different
types of shells (e.g. FilesystemShell, ValueShell, etc.). Should resolve issue #604.

Expand functionality of the pwd command to better handle the different
types of shells (e.g. FilesystemShell, ValueShell, etc.).
@@ -1,9 +1,9 @@
use crate::commands::WholeStreamCommand;
// use crate::data::{Dictionary, Value};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought I got them all, but missed a couple, I will remove them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

use crate::parser::registry::Signature;
use crate::prelude::*;
use indexmap::IndexMap;
// use indexmap::IndexMap;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@andrasio andrasio merged commit 6c5da7d into nushell:master Sep 7, 2019
elferherrera pushed a commit to elferherrera/nushell that referenced this pull request Feb 7, 2022
kubouch pushed a commit that referenced this pull request Feb 7, 2022
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this pull request Jan 27, 2023
* [WIP] Release notes for nushell 0.70

Please add your important new features and breaking changes to the
release notes by commiting to/opening a PR against the
`release-notes-0.70` branch! Thanks for helping out!

* update blog (nushell#615)

* add text about new table flags

took text from zhiburt's pr and put it here

* Mention `features extra` in the release notes

* Include rename to `query df`

Account for nushell#6777

* Update 2022-10-18-nushell-0_70.md

* Update 2022-10-18-nushell-0_70.md

* Update 2022-10-18-nushell-0_70.md

* Update 2022-10-18-nushell-0_70.md

* Update 2022-10-18-nushell-0_70.md

Co-authored-by: pwygab <88221256+merelymyself@users.noreply.github.com>
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants