Rename query dfr -> query df#6777
Merged
sholderbach merged 1 commit intonushell:mainfrom Oct 16, 2022
Merged
Conversation
Member
|
Good call! Do we have any public scripts that need to be updated? |
Contributor
Author
|
Doesn't seem to be anything in https://github.com/nushell/nu_scripts. It's only been around for 1 month. |
Member
|
https://cs.github.com/?scopeName=All+repos&scope=&q=org%3Anushell+query+df Yeah github code search is not returning any other hits. |
sholderbach
added a commit
to nushell/nushell.github.io
that referenced
this pull request
Oct 16, 2022
Account for nushell/nushell#6777
sophiajt
added a commit
to nushell/nushell.github.io
that referenced
this pull request
Oct 19, 2022
* [WIP] Release notes for nushell 0.70 Please add your important new features and breaking changes to the release notes by commiting to/opening a PR against the `release-notes-0.70` branch! Thanks for helping out! * update blog (#615) * add text about new table flags took text from zhiburt's pr and put it here * Mention `features extra` in the release notes * Include rename to `query df` Account for nushell/nushell#6777 * Update 2022-10-18-nushell-0_70.md * Update 2022-10-18-nushell-0_70.md * Update 2022-10-18-nushell-0_70.md * Update 2022-10-18-nushell-0_70.md * Update 2022-10-18-nushell-0_70.md Co-authored-by: pwygab <88221256+merelymyself@users.noreply.github.com> Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com> Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
query dfrtoquery df.query dfis clearly the appropriate name here:dfis already widely used in various contexts in nushell to refer to dataframe, including in the commandinto df, whereas "dfr" is no longer used anywhere else. (I understand that previously dataframe commands were prefixed withdfrbut the stringdfrdoesn't occur anywhere in the codebase after this change). The help text of the command statesmaking it even more clear that the command should use the abbreviation
df.Tests
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all the tests passDocumentation
I believe that the relevant content is automatically generated and so will be updated automatically in due course: https://www.nushell.sh/book/commands/query_dfr.html#frontmatter-title-for-dataframe