Skip to content

Nullable and fix lock in SQLiteWallet#3816

Merged
shargon merged 7 commits intomasterfrom
sql-wallet-nullable
Mar 16, 2025
Merged

Nullable and fix lock in SQLiteWallet#3816
shargon merged 7 commits intomasterfrom
sql-wallet-nullable

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 10, 2025 •
edited
Loading

Description

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Current tess

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon changed the title Nullable and fix lock Nullable and fix lock in SQLiteWallet Mar 10, 2025
@shargon shargon changed the title Nullable and fix lock in SQLiteWallet Nullable and fix lock in SQLiteWallet Mar 10, 2025
@Jim8y
Copy link
Contributor

Jim8y commented Mar 11, 2025

can you @shargon to have a pr that fixes all var, all _ or any style issues?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Mar 11, 2025

he doesnt want big PRs

@shargon
Copy link
Member Author

shargon commented Mar 11, 2025

he doesnt want big PRs

? 1 file is big?

@shargon shargon mentioned this pull request Mar 11, 2025
Merged
16 tasks
@shargon
Copy link
Member Author

shargon commented Mar 11, 2025

can you @shargon to have a pr that fixes all var, all _ or any style issues?

Done @Jim8y, please take a look to #3818

@shargon
Copy link
Member Author

shargon commented Mar 13, 2025 •
edited
Loading

My bad, @neo-project/core Sorrry I pushed to master, reverted

@Wi1l-B0t
Copy link
Contributor

Wi1l-B0t commented Mar 13, 2025 •
edited
Loading

The master branch has some commits from here.

These commits need to be reverted?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Mar 13, 2025

he doesnt want big PRs

? 1 file is big?

I thought he meant the whole repo or project.

@shargon
Copy link
Member Author

shargon commented Mar 13, 2025

The master branch has some commits from here.

These commits need to be reverted?

Already reverted

@Wi1l-B0t
Copy link
Contributor

Wi1l-B0t commented Mar 13, 2025

The master branch has some commits from here.
These commits need to be reverted?

Already reverted

https://github.com/neo-project/neo/commits/master/

Why many commits in recent hours?

@shargon
Copy link
Member Author

shargon commented Mar 13, 2025

The master branch has some commits from here.
These commits need to be reverted?

Already reverted

https://github.com/neo-project/neo/commits/master/

Why many commits in recent hours?

As I said, I was pushing to master, and was reverted already

@Wi1l-B0t
Copy link
Contributor

Wi1l-B0t commented Mar 13, 2025

The master branch has some commits from here.
These commits need to be reverted?

Already reverted

https://github.com/neo-project/neo/commits/master/
Why many commits in recent hours?

As I said, I was pushing to master, and was reverted already

OK

@shargon shargon merged commit 8bafc10 into master Mar 16, 2025
6 checks passed
@shargon shargon deleted the sql-wallet-nullable branch March 16, 2025 20:28
Jim8y added a commit that referenced this pull request Mar 24, 2025
@Jim8y
Merge branch 'master' into pr/3390
a6617e8 
* master: (52 commits)
  Add SHA512 (#3845)
  Clean crypto (#3844)
  Review of #3782 (#3843)
  [`Fix`] References in `StorageKey` (#3782)
  Ensure `IInteroperable.Clone` (#3829)
  Ensure the interop types are serializable before commit (#3802)
  fix: ModInverse extension in BigIntegerExtensions (#3840)
  Style: avoid allocating emtpy array (#3841)
  Style: format json in tests/ (#3839)
  Reduce mem arguments (#3838)
  Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823)
  style: use proper Assert methods (#3834)
  Nullable and fix `lock` in `SQLiteWallet` (#3816)
  [`Add`]: `Witness.Empty` for simplifing somethings (#3836)
  Style: format too-long literal strings (#3835)
  Add: NotNullWhen(true) for some out parameters (#3833)
  Update SQLiteWallet.cs (#3830)
  Revert "Optimize DeleteAccount"
  Revert "add lock to Version"
  Revert "Optimize LoadAccounts"
  ...

# Conflicts:
#	neo.sln
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @cschuchardt88
Nullable and fix lock in SQLiteWallet (neo-project#3816)
d75140a 
* fix

* Update SQLiteWallet.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

No one assigned

Labels

Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A concurrency problem in SQLiteWallet because of across execution

4 participants

@shargon @Jim8y @cschuchardt88 @Wi1l-B0t