Avoid returning the entire mempool when only maxTransactionsPerBlock is required#3823
Merged
Avoid returning the entire mempool when only maxTransactionsPerBlock is required#3823
maxTransactionsPerBlock is required#3823Conversation
vncoelho
reviewed
Mar 15, 2025
Member
vncoelho
left a comment
There was a problem hiding this comment.
I will review asap. Please wait before merge
vncoelho
approved these changes
Mar 17, 2025
AnnaShaleva
approved these changes
Mar 17, 2025
Jim8y
added a commit
that referenced
this pull request
Mar 24, 2025
* master: (52 commits) Add SHA512 (#3845) Clean crypto (#3844) Review of #3782 (#3843) [`Fix`] References in `StorageKey` (#3782) Ensure `IInteroperable.Clone` (#3829) Ensure the interop types are serializable before commit (#3802) fix: ModInverse extension in BigIntegerExtensions (#3840) Style: avoid allocating emtpy array (#3841) Style: format json in tests/ (#3839) Reduce mem arguments (#3838) Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823) style: use proper Assert methods (#3834) Nullable and fix `lock` in `SQLiteWallet` (#3816) [`Add`]: `Witness.Empty` for simplifing somethings (#3836) Style: format too-long literal strings (#3835) Add: NotNullWhen(true) for some out parameters (#3833) Update SQLiteWallet.cs (#3830) Revert "Optimize DeleteAccount" Revert "add lock to Version" Revert "Optimize LoadAccounts" ... # Conflicts: # neo.sln
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
…` is required (neo-project#3823) * Reduce full mempool when not needed * return array --------- Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When consensus require the transaction list in mempool, it always take the
maxTransactionsPerBlock, so there is no need to return all the transactions (maybe 50k) converted as an array for it.This change will improve the tps
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: