[Add]: Witness.Empty for simplifing somethings#3836
Merged
shargon merged 4 commits intoneo-project:masterfrom Mar 16, 2025
Merged
[Add]: Witness.Empty for simplifing somethings#3836shargon merged 4 commits intoneo-project:masterfrom
Add]: Witness.Empty for simplifing somethings#3836shargon merged 4 commits intoneo-project:masterfrom
Conversation
shargon
reviewed
Mar 16, 2025
shargon
previously approved these changes
Mar 16, 2025
shargon
reviewed
Mar 16, 2025
shargon
previously approved these changes
Mar 16, 2025
shargon
approved these changes
Mar 16, 2025
Contributor
|
@shargon please give us some time to check those prs, now prs are merged so fast~~~~ |
Jim8y
added a commit
that referenced
this pull request
Mar 24, 2025
* master: (52 commits) Add SHA512 (#3845) Clean crypto (#3844) Review of #3782 (#3843) [`Fix`] References in `StorageKey` (#3782) Ensure `IInteroperable.Clone` (#3829) Ensure the interop types are serializable before commit (#3802) fix: ModInverse extension in BigIntegerExtensions (#3840) Style: avoid allocating emtpy array (#3841) Style: format json in tests/ (#3839) Reduce mem arguments (#3838) Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823) style: use proper Assert methods (#3834) Nullable and fix `lock` in `SQLiteWallet` (#3816) [`Add`]: `Witness.Empty` for simplifing somethings (#3836) Style: format too-long literal strings (#3835) Add: NotNullWhen(true) for some out parameters (#3833) Update SQLiteWallet.cs (#3830) Revert "Optimize DeleteAccount" Revert "add lock to Version" Revert "Optimize LoadAccounts" ... # Conflicts: # neo.sln
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
* Add: Witness.Empty for simplifing somethings * Update src/Neo/Network/P2P/Payloads/Witness.cs * Update src/Neo/Network/P2P/Payloads/Witness.cs --------- Co-authored-by: Shargon <shargon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are many code lines like this
This pr adds
Witness.Emptyto simplify these.And simplifies some arrya initializations.
Type of change
Checklist: