Skip to content

[MemPool] Remove constant arguments#3838

Merged
shargon merged 2 commits intomasterfrom
reduce_me_args
Mar 17, 2025
Merged

[MemPool] Remove constant arguments#3838
shargon merged 2 commits intomasterfrom
reduce_me_args

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 17, 2025 •
edited
Loading

Description

Make easier the review of #3822

  • GetLowestFeeTransaction and ReverifyTransactions used always the same args for all calls.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon changed the title Reduce mem arguments [MemPool] Reduce constant arguments Mar 17, 2025
@shargon shargon changed the title [MemPool] Reduce constant arguments [MemPool] Remove constant arguments Mar 17, 2025
AnnaShaleva
AnnaShaleva approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK, although I'm not sure why it wasn't like that before, so it looks like a legacy.

@Wi1l-B0t
Copy link
Contributor

Wi1l-B0t commented Mar 17, 2025

LGTM

@shargon shargon merged commit 6109a9f into master Mar 17, 2025
6 checks passed
@shargon shargon deleted the reduce_me_args branch March 17, 2025 17:49
Jim8y added a commit that referenced this pull request Mar 24, 2025
@Jim8y
Merge branch 'master' into pr/3390
a6617e8 
* master: (52 commits)
  Add SHA512 (#3845)
  Clean crypto (#3844)
  Review of #3782 (#3843)
  [`Fix`] References in `StorageKey` (#3782)
  Ensure `IInteroperable.Clone` (#3829)
  Ensure the interop types are serializable before commit (#3802)
  fix: ModInverse extension in BigIntegerExtensions (#3840)
  Style: avoid allocating emtpy array (#3841)
  Style: format json in tests/ (#3839)
  Reduce mem arguments (#3838)
  Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823)
  style: use proper Assert methods (#3834)
  Nullable and fix `lock` in `SQLiteWallet` (#3816)
  [`Add`]: `Witness.Empty` for simplifing somethings (#3836)
  Style: format too-long literal strings (#3835)
  Add: NotNullWhen(true) for some out parameters (#3833)
  Update SQLiteWallet.cs (#3830)
  Revert "Optimize DeleteAccount"
  Revert "add lock to Version"
  Revert "Optimize LoadAccounts"
  ...

# Conflicts:
#	neo.sln
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @cschuchardt88
Reduce mem arguments (neo-project#3838)
e9933a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vncoelho vncoelho vncoelho approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

No one assigned

Labels

Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @Wi1l-B0t @vncoelho @AnnaShaleva