Skip to content

Review of #3782#3843

Merged
shargon merged 3 commits intomasterfrom
review-3782
Mar 21, 2025
Merged

Review of #3782#3843
shargon merged 3 commits intomasterfrom
review-3782

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 21, 2025 •
edited
Loading

Description

Related to #3782 (review)

  • Avoid duplicate arrays when are constructed by the static method

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Current tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon merged commit b271253 into master Mar 21, 2025
7 checks passed
@shargon shargon deleted the review-3782 branch March 21, 2025 15:55
Jim8y added a commit that referenced this pull request Mar 24, 2025
@Jim8y
Merge branch 'master' into pr/3390
a6617e8 
* master: (52 commits)
  Add SHA512 (#3845)
  Clean crypto (#3844)
  Review of #3782 (#3843)
  [`Fix`] References in `StorageKey` (#3782)
  Ensure `IInteroperable.Clone` (#3829)
  Ensure the interop types are serializable before commit (#3802)
  fix: ModInverse extension in BigIntegerExtensions (#3840)
  Style: avoid allocating emtpy array (#3841)
  Style: format json in tests/ (#3839)
  Reduce mem arguments (#3838)
  Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823)
  style: use proper Assert methods (#3834)
  Nullable and fix `lock` in `SQLiteWallet` (#3816)
  [`Add`]: `Witness.Empty` for simplifing somethings (#3836)
  Style: format too-long literal strings (#3835)
  Add: NotNullWhen(true) for some out parameters (#3833)
  Update SQLiteWallet.cs (#3830)
  Revert "Optimize DeleteAccount"
  Revert "add lock to Version"
  Revert "Optimize LoadAccounts"
  ...

# Conflicts:
#	neo.sln
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @cschuchardt88
Review of neo-project#3782 (neo-project#3843)
6a5fc26 
* Review of neo-project#3782

* Clean

* Add note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jim8y Jim8y Jim8y approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shargon @Jim8y @Wi1l-B0t