Skip to content

[crypto] Add SHA512#3845

Merged
shargon merged 2 commits intomasterfrom
crypto-sha512
Mar 22, 2025
Merged

[crypto] Add SHA512#3845
shargon merged 2 commits intomasterfrom
crypto-sha512

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 21, 2025 •
edited
Loading

Description

Related to #3837
This change is not supposed to make it accessible to the VM, so it does not require HF.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestSha512

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon merged commit 7fac685 into master Mar 22, 2025
7 checks passed
@shargon shargon deleted the crypto-sha512 branch March 22, 2025 18:59
Jim8y added a commit that referenced this pull request Mar 24, 2025
@Jim8y
Merge branch 'master' into pr/3390
a6617e8 
* master: (52 commits)
  Add SHA512 (#3845)
  Clean crypto (#3844)
  Review of #3782 (#3843)
  [`Fix`] References in `StorageKey` (#3782)
  Ensure `IInteroperable.Clone` (#3829)
  Ensure the interop types are serializable before commit (#3802)
  fix: ModInverse extension in BigIntegerExtensions (#3840)
  Style: avoid allocating emtpy array (#3841)
  Style: format json in tests/ (#3839)
  Reduce mem arguments (#3838)
  Avoid returning the entire mempool when only `maxTransactionsPerBlock` is required (#3823)
  style: use proper Assert methods (#3834)
  Nullable and fix `lock` in `SQLiteWallet` (#3816)
  [`Add`]: `Witness.Empty` for simplifing somethings (#3836)
  Style: format too-long literal strings (#3835)
  Add: NotNullWhen(true) for some out parameters (#3833)
  Update SQLiteWallet.cs (#3830)
  Revert "Optimize DeleteAccount"
  Revert "add lock to Version"
  Revert "Optimize LoadAccounts"
  ...

# Conflicts:
#	neo.sln
@mialbu mialbu mentioned this pull request Apr 28, 2025
Closed
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @cschuchardt88
Add SHA512 (neo-project#3845)
40d2d84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

+1 more reviewer

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shargon @cschuchardt88 @Jim8y @vncoelho @Wi1l-B0t