Skip to content

Style SQLiteWallet#3818

Merged
shargon merged 8 commits intomasterfrom
style-sqliwallet
Mar 13, 2025
Merged

Style SQLiteWallet#3818
shargon merged 8 commits intomasterfrom
style-sqliwallet

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 11, 2025 •
edited
Loading

Description

Related to #3816 (comment)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon added Waiting for Review Easy-to-Review a simple edit; just a few lines labels Mar 11, 2025
@shargon shargon requested a review from Jim8y March 11, 2025 10:36
@shargon shargon mentioned this pull request Mar 11, 2025
Merged
15 tasks
Wi1l-B0t
Wi1l-B0t reviewed Mar 11, 2025
View reviewed changes
Wi1l-B0t
Wi1l-B0t previously approved these changes Mar 11, 2025
View reviewed changes
Wi1l-B0t
Wi1l-B0t reviewed Mar 12, 2025
View reviewed changes
shargon and others added 2 commits March 12, 2025 15:27
@shargon @Wi1l-B0t
Update src/Plugins/SQLiteWallet/SQLiteWallet.cs
d70c255 
Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
@shargon
Merge branch 'master' into style-sqliwallet
d5a838a
@shargon shargon merged commit bab9ed0 into master Mar 13, 2025
6 checks passed
@shargon shargon deleted the style-sqliwallet branch March 13, 2025 09:26
@shargon shargon mentioned this pull request Mar 13, 2025
Merged
16 tasks
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @Wi1l-B0t @cschuchardt88
Style SQLiteWallet (neo-project#3818)
029643b 
* Style Sqlite wallet

* more var

* var

* Will's review

* Update src/Plugins/SQLiteWallet/SQLiteWallet.cs

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees

No one assigned

Labels

Easy-to-Review a simple edit; just a few lines Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shargon @Wi1l-B0t