Merged
Conversation
Previously we would always deserialize the input. However in situations where we register the plugin directly on the scheduler (such as within a preload) this isn't necessary.
Disable HTTP API by default (dask#6420)
Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#6444) the PeriodicCallbacks in self.periodic_callbacks need to be started and stopped on the same loop as self.loop because they bind to IOLoop.current() when PeriodicCallback.start is called When running a synchronous Cluster the loop will be running in a different thread to where cluster._ipython_widget_ is called from
This causes problems with certain kinds of views. So just pass the `memoryview` as-is even though `PickleBuffer` will chain the underlying `memoryview`s instead of referencing the original `obj`. Maybe this can be fixed upstream.
Tests like dask#6395 will fail (timeout) because a log statement doesn't get printed, but since you never get to see what _was_ printed, CI failuers are hard to debug. Adds a `wait_for_log_line` helper that tees the output to stdout, so you can at least see what happened.
refs dask#6163 Passing anything other than `IOLoop.current()` will fail when you try to use the Scheduler anyway: self._lock will be bound to `IOLoop.current().asyncio_loop` aka `asyncio.get_running_loop()`: https://github.com/dask/distributed/blob/fc42dbd89afa4ab6709b197db5c2a14c284e99bf/distributed/scheduler.py#L2923 and start_http_server runs on the IOLoop.current() also: https://github.com/dask/distributed/blob/fc42dbd89afa4ab6709b197db5c2a14c284e99bf/distributed/scheduler.py#L2963
) distributed/tests/test_profile.py fails occasionally (e.g., see dask#6444 (comment)). This test restructures the test to avoid timing-based flakes.
Owner
|
Thanks! Merging, mostly without review. Also, do you have commit rights to dask/dask? If so, you should be able to push directly to my branch. In general you (or any maintainer) should always feel comfortable doing this. I can rebase things away if I don't like them, and I find that I like 99% of pushes to my branches. |
Owner
|
Ah! you don't have commit rights to distributed, right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
mainand fixing some conflicts.