Skip to content

Update nuke-hlg#5

Merged
mrocklin merged 335 commits intomrocklin:nuke-hlgfrom
rjzamora:nuke-hlg
Aug 25, 2022
Merged

Update nuke-hlg#5
mrocklin merged 335 commits intomrocklin:nuke-hlgfrom
rjzamora:nuke-hlg

Conversation

@rjzamora
Copy link
Copy Markdown

Merging main and fixing some conflicts.

mrocklin and others added 30 commits May 20, 2022 13:46
Previously we would always deserialize the input.
However in situations where we register the plugin directly on the
scheduler (such as within a preload) this isn't necessary.
Not entirely sure why, but `@functools.wraps` on the test function makes them show up. This is convenient when VSCode users want to debug a `@gen_test` test.
Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ask#6421)

Adds a Lock to distributed.profile to enable better concurrency control. In particular, it allows running garbage collection without a profiling thread holding references to objects, which is necessary for dask#6250.
…#6444)

the PeriodicCallbacks in self.periodic_callbacks need to be started and stopped on the same loop as self.loop because they bind to IOLoop.current() when PeriodicCallback.start is called

When running a synchronous Cluster the loop will be running in a different thread to where cluster._ipython_widget_ is called from
This causes problems with certain kinds of views. So just pass the
`memoryview` as-is even though `PickleBuffer` will chain the underlying
`memoryview`s instead of referencing the original `obj`. Maybe this can
be fixed upstream.
Tests like dask#6395 will fail (timeout) because a log statement doesn't get printed, but since you never get to see what _was_ printed, CI failuers are hard to debug.

Adds a `wait_for_log_line` helper that tees the output to stdout, so you can at least see what happened.
refs dask#6163 

Passing anything other than `IOLoop.current()` will fail when you try to use the Scheduler anyway:
self._lock will be bound to `IOLoop.current().asyncio_loop` aka `asyncio.get_running_loop()`:
https://github.com/dask/distributed/blob/fc42dbd89afa4ab6709b197db5c2a14c284e99bf/distributed/scheduler.py#L2923
and start_http_server runs on the IOLoop.current() also:
https://github.com/dask/distributed/blob/fc42dbd89afa4ab6709b197db5c2a14c284e99bf/distributed/scheduler.py#L2963
)

distributed/tests/test_profile.py fails occasionally (e.g., see dask#6444 (comment)). This test restructures the test to avoid timing-based flakes.
hendrikmakait and others added 27 commits August 12, 2022 15:13
)

So that the progress bar diagnostic doesn't interfere with other print
statements or logging by the user.
@mrocklin
Copy link
Copy Markdown
Owner

Thanks! Merging, mostly without review.

Also, do you have commit rights to dask/dask? If so, you should be able to push directly to my branch. In general you (or any maintainer) should always feel comfortable doing this. I can rebase things away if I don't like them, and I find that I like 99% of pushes to my branches.

@mrocklin mrocklin merged commit 16eb77b into mrocklin:nuke-hlg Aug 25, 2022
@mrocklin
Copy link
Copy Markdown
Owner

Ah! you don't have commit rights to distributed, right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.