Fix resource deallocation for resumed tasks#6914
Merged
Conversation
919cfbd to
3fa2d20
Compare
3fa2d20 to
336cac0
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 35m 48s ⏱️ + 8m 13s For more details on these failures, see this check. Results for commit 336cac0. ± Comparison against base commit 58a5a3c. |
hendrikmakait
approved these changes
Aug 19, 2022
Member
hendrikmakait
left a comment
There was a problem hiding this comment.
LGTM, thanks @crusaderky!
|
|
||
| @pytest.mark.parametrize("done_ev_cls", [ExecuteSuccessEvent, ExecuteFailureEvent]) | ||
| def test_resumed_with_different_resources(ws_with_running_task, done_ev_cls): | ||
| """A task with resources is cancelled and then resumed to the same state, but with |
Member
There was a problem hiding this comment.
Thanks for adding an explanation here!
fjetter
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6915