Handle failing plugin.close() calls during scheduler shutdown#6450
Merged
jrbourbeau merged 4 commits intodask:mainfrom May 26, 2022
Merged
Handle failing plugin.close() calls during scheduler shutdown#6450jrbourbeau merged 4 commits intodask:mainfrom
plugin.close() calls during scheduler shutdown#6450jrbourbeau merged 4 commits intodask:mainfrom
Conversation
Contributor
graingert
reviewed
May 26, 2022
graingert
reviewed
May 26, 2022
Member
Author
|
Sure. I was just being lazy. pushed up |
jrbourbeau
approved these changes
May 26, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @mrocklin. This looks like a reasonable addition. I've left a couple of nice-to-have, but not blocking comments
Comment on lines
+236
to
+237
| assert "123" in out | ||
| assert "456" in out |
Member
There was a problem hiding this comment.
It would also be nice to check that the logger exceptions also occurred as expected
| try: | ||
| await func() | ||
| except Exception: | ||
| logger.exception("Plugin call failed during scheduler.close") |
Member
There was a problem hiding this comment.
Including the plugin name in this message would be nice because as is we just know that some plugin method failed, but not which plugin
Member
There was a problem hiding this comment.
logger.exception includes the traceback which should include the plugin class name, although it could be a base class that fails
Member
|
rerun tests Note: rerunning gpuCI tests since those errors should be fixed by #6434 |
plugin.close() calls during scheduler shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.