Skip to content

Remove duplicated code when validating in_flight_tasks#6917

Merged
crusaderky merged 1 commit intodask:mainfrom
crusaderky:validate_in_flight_tasks
Aug 19, 2022
Merged

Remove duplicated code when validating in_flight_tasks#6917
crusaderky merged 1 commit intodask:mainfrom
crusaderky:validate_in_flight_tasks

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Aug 18, 2022

Remove duplicated, commented out checks that already happen a few lines below
Closes #6708

@crusaderky crusaderky force-pushed the validate_in_flight_tasks branch from b0599ba to e8c7d3b Compare August 18, 2022 19:35
@crusaderky crusaderky changed the title Validate in_flight_tasks Remove duplicated code when validating in_flight_tasks Aug 18, 2022
@crusaderky crusaderky self-assigned this Aug 18, 2022
@crusaderky crusaderky marked this pull request as ready for review August 18, 2022 19:37
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 34m 46s ⏱️ + 7m 11s
  3 005 tests ±0    2 921 ✔️ +1    82 💤 ±0  2  - 1 
22 239 runs  ±0  21 274 ✔️ +4  963 💤  - 3  2  - 1 

For more details on these failures, see this check.

Results for commit e8c7d3b. ± Comparison against base commit 58a5a3c.

Copy link
Copy Markdown
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crusaderky crusaderky merged commit 3bae769 into dask:main Aug 19, 2022
@crusaderky crusaderky deleted the validate_in_flight_tasks branch August 19, 2022 14:06
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate all state-based collections in WorkerState

2 participants