close client in sync test_actor tests#6459
Merged
Conversation
Member
|
Looks good to me. Merging after CI. Any reason to keep this as a draft? |
Member
Author
was waiting for tests, but you're right just moving the client to the |
Member
|
To me Draft state means "the author doesn't yet want this to be merged" and non-green tests means "the robots don't yet want this to be merged". If you think that this is likely going to be ok, pending the review of the bots, then I think it's ok to drop the Draft status. That's just how my thinking works though. Others may have other opinions. |
Contributor
Member
|
Both failures are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #6453
Not sure if this is a fix, but closing the client explicitly usually helps with unclosed comms
pre-commit run --all-files