Make gen_tests show up in VSCode test discovery#6424
Merged
jrbourbeau merged 1 commit intodask:mainfrom May 23, 2022
Merged
Conversation
Not entirely sure why, but `@functools.wraps` on the test function makes them show up. This is convenient when VSCode users want to debug a `@gen_test` test.
Contributor
jrbourbeau
approved these changes
May 23, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
This seems fine to me -- thanks @gjoseph92
Noting that tests failures here are unrelated
Member
|
This is pretty subtle -- is it something we could easily add a test for? EDIT: Merging for now as this change is harmless (famous last words) and improves the VS Code dev experience. Feel free to push up a test in a follow-up PR is you've got the bandwidth |
Member
|
fyi this means that gen_test now supports marks either side of the @pytest.mark.example
@gen_test()
@pytest.mark.example
def test_example():
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not entirely sure why, but
@functools.wrapson the test function makes them show up. This is convenient when VSCode users want to debug a@gen_testtest.pre-commit run --all-files