Don't use bokeh Figure in tests#6721
Merged
jrbourbeau merged 1 commit intodask:mainfrom Aug 17, 2022
bryevdv:patch-1
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 27m 50s ⏱️ + 7m 7s For more details on these failures, see this check. Results for commit 18d5b6f. ± Comparison against base commit e8ffed7. |
jrbourbeau
approved these changes
Aug 17, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @bryevdv! Apologies for the delayed response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @jrbourbeau
This PR removes the use of
bokeh.plotting.Figurein tests, sinceFigurewill be removed in Bokeh 3.0I edited this in the GH web UI, and have not actually run anything, so we will see how this goes.