Skip to content

ignore coroutine 'ServerSession\.with_document_locked' was never awaited#6447

Merged
fjetter merged 1 commit intodask:mainfrom
graingert:ignore-new-bokeh-unawaited-coroutine
May 25, 2022
Merged

ignore coroutine 'ServerSession\.with_document_locked' was never awaited#6447
fjetter merged 1 commit intodask:mainfrom
graingert:ignore-new-bokeh-unawaited-coroutine

Conversation

@graingert
Copy link
Copy Markdown
Member

@graingert graingert commented May 25, 2022 •
edited
Loading

Closes #6394

  • Tests added / passed
  • Passes pre-commit run --all-files

failure from https://github.com/graingert/distributed/runs/6593930661?check_suite_focus=true#step:11:1759


>               warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E               pytest.PytestUnraisableExceptionWarning: Exception ignored in: <coroutine object ServerSession.with_document_locked at 0x7f69604daf10>
E               
E               Traceback (most recent call last):
E                 File "/usr/share/miniconda3/envs/dask-distributed/lib/python3.10/warnings.py", line 506, in _warn_unawaited_coroutine
E                   warn(msg, category=RuntimeWarning, stacklevel=2, source=coro)
E               RuntimeWarning: coroutine 'ServerSession.with_document_locked' was never awaited

/usr/share/miniconda3/envs/dask-distributed/lib/python3.10/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning
------------------------------ Captured log call -------------------------------
ERROR    asyncio:base_events.py:1744 Task was destroyed but it is pending!
task: <Task pending name='Task-22382' coro=<ServerSession.with_document_locked() running at /usr/share/miniconda3/envs/dask-distributed/lib/python3.10/site-packages/bokeh/server/session.py:78> cb=[multi_future.<locals>.callback() at /usr/share/miniconda3/envs/dask-distributed/lib/python3.10/site-packages/tornado/gen.py:520]>
- generated xml file: /home/runner/work/distributed/distributed/reports/pytest.xml -

traceback source from the destroyed task:

https://github.com/bokeh/bokeh/blob/a1931d48512a1cb369746025d48344a6ad1834b2/bokeh/server/session.py#L78
https://github.com/tornadoweb/tornado/blob/2047e7ae3c825bf52dad10cc8402d09e11091bc1/tornado/gen.py#L520

see also bokeh/bokeh#11976

@graingert graingert changed the title ignore ServerSession.with_document_locked unawaited ignore coroutine 'ServerSession\.with_document_locked' was never awaited May 25, 2022
@graingert graingert mentioned this pull request May 25, 2022
Merged
3 tasks
@graingert graingert mentioned this pull request May 25, 2022
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 25, 2022

Unit Test Results

       15 files  ±0         15 suites  ±0   6h 17m 5s ⏱️ - 7m 28s
  2 812 tests ±0    2 732 ✔️ +1    79 💤 ±0  1 ❌  - 1 
20 847 runs  ±0  19 911 ✔️  - 1  935 💤 +2  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 4cfb6dd. ± Comparison against base commit dea9ef2.

@fjetter fjetter merged commit 046ab17 into dask:main May 25, 2022
@graingert graingert deleted the ignore-new-bokeh-unawaited-coroutine branch October 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrocklin mrocklin mrocklin approved these changes

@fjetter fjetter fjetter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

distributed/dashboard/tests/test_scheduler_bokeh.py::test_basic flaky

3 participants

@graingert @mrocklin @fjetter