✨ feat(page-share): add document share flow with business slot stubs#15309
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb23f11d41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Suspense fallback={<Loading debugId="DesktopMainLayout > Outlet" />}> | ||
| <Outlet /> |
There was a problem hiding this comment.
Pass the share probe through the outlet
For public /page/:id visits by anonymous or non-owner users, PagesPage now only switches to ReadOnlyPageViewer when useOutletContext() contains probe, but this parent <Outlet /> is rendered without any context. That means the shared-page probe result can never reach the child route, so shared links fall through to the normal PageExplorer path and hit the authed document APIs instead of rendering the published/private share view described by the middleware comment.
Useful? React with 👍 / 👎.
fb23f11 to
6a1ecc9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15309 +/- ##
===========================================
- Coverage 89.71% 71.14% -18.58%
===========================================
Files 860 3183 +2323
Lines 105013 318335 +213322
Branches 9199 33819 +24620
===========================================
+ Hits 94217 226476 +132259
- Misses 10624 91687 +81063
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Drop anonymous handling on /page/:id: revert middleware allowlist, main layout PageShareLayout wrap, and outlet-context probe branch - Add /share/page/:id route under share tree (parallel to /share/t/:id), registered in desktop/desktop-vite/mobile router configs - New PublishedShell business slot stub (pass-through); cloud provides the marketing banner + chrome - Align SharePopover i18n schema with the topic-share pattern
d27b251 to
6920b8c
Compare
…ype-check
The /share/page/:id route calls lambdaClient.pageShare.getSharedDocument;
the empty router({}) stub left the OSS standalone type-check unable to
resolve it. Stub now declares all three procedures (getShareSettings,
updateShareSettings, getSharedDocument) with cloud-matching inputs and
throws NOT_FOUND when invoked without the cloud override.
Merges upstream/canary into main, resolving all conflicts in favor of upstream. Key changes pulled in from upstream include: - feat(page-share): document share flow with business slot stubs (lobehub#15309) - feat(device): connectionId + channel routing in gateway client & device list (lobehub#15322) - fix(desktop): upload .blockmap files to S3 for differential updates (lobehub#15326) - docs(spa-routes): document .desktop.{ts,tsx} variant pattern (lobehub#15327) - chore: update @lobehub/ui to v5.15.5 (lobehub#15325) - New builtin-tool skill and data-fetching-architecture skill added - Various skill/agent doc updates (i18n, linear, local-testing, store-data-structures, etc.) - Database model and repository updates (topic, userMemory models, bm25, search index) - Google createImage provider updates - Navigation layout hook updates - GitHub Actions workflow restored (issue-auto-comments.yml) All merge conflicts resolved by accepting upstream versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…obehub#15309) * ✨ feat(page-share): add document share flow * ✨ improve page share probe fallback * ♻️ refactor(page-share): extract to business slot stubs * ♻️ refactor(page-share): move shared-page viewer to /share/page/:id - Drop anonymous handling on /page/:id: revert middleware allowlist, main layout PageShareLayout wrap, and outlet-context probe branch - Add /share/page/:id route under share tree (parallel to /share/t/:id), registered in desktop/desktop-vite/mobile router configs - New PublishedShell business slot stub (pass-through); cloud provides the marketing banner + chrome - Align SharePopover i18n schema with the topic-share pattern * 🐛 fix(page-share): provide pageShare router stub procedures for OSS type-check The /share/page/:id route calls lambdaClient.pageShare.getSharedDocument; the empty router({}) stub left the OSS standalone type-check unable to resolve it. Stub now declares all three procedures (getShareSettings, updateShareSettings, getSharedDocument) with cloud-matching inputs and throws NOT_FOUND when invoked without the cloud override.
# 🚀 LobeHub Release (20260604) **Release Date:** June 4, 2026 **Since v2.2.1:** 88 merged PRs · 11 contributors > This week brings Execution Devices out of the lab — run agents and Claude Code on any configured local or remote machine — alongside Claude Opus 4.8, token-usage analytics, and Page sharing. --- ## ✨ Highlights - **Execution Devices** — Pick where an agent runs. Desktop and CLI devices auto-register with a stable machine ID, route through the gateway by channel, and surface a device switcher in the chat input. Run remote Claude Code on a configured device, with a recent-directory picker you can drag to reorder. (#15300, #15315, #15322, #15343, #15351, #15371) - **Claude Opus 4.8** — Day-one support for Anthropic's latest model. (#15314) - **Token-usage analytics** — A new token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup so totals stay accurate without recomputing from messages. (#15365, #15417, #15425) - **Page sharing** — Share a Page through a dedicated document share flow, plus new Workspace and Agent share tables. (#15309, #15439) - **Self-iteration agents** — Agent Signal's execAgent migration lands a server-runtime bridge, async memory writer, and a registered self-iteration tool package, with a CLI trigger command for testing. (#15360, #15364, #15392) - **Knowledge search** — BM25 search now extends to file-backed documents, and the portal ships an editable CodeMirror viewer for local files with document highlighting. (#15247, #15298) --- ## 🏗️ Core Agent & Architecture ### Agent Signal & Runtime - **execAgent migration** — Server-runtime bridge, completion projection, async memory writer, and removal of the legacy `executeSelfIteration` path. (#15392) - Registered the self-iteration builtin tool package and restored the three mode-specific self-iteration agent slugs. (#15202, #15364) - Added a CLI trigger command with a golden-snapshot fixture for Agent Signal. (#15360) - **Skill priority** — Agent Builder now emits a skill-priority instruction with matching server runtime. (#15409) - Retry empty LLM completions instead of silently finishing the turn. (#15355) - Classify topic/agent/session foreign-key violations as `ConversationParentMissing` for clearer recovery. (#15408) - Persist canonical nested usage/performance on assistant messages, and re-link orphan tool messages at the raw bucket write boundary. (#15359, #15438) - Guard `createAgent` against LLM double-encoded array fields. (#15381) --- ## 🖥️ Execution Devices & Gateway - Auto-register desktop and CLI devices with a stable machine ID, and add the `@lobechat/device-identity` package. (#15300, #15321) - New Devices settings page behind the Execution Device Switcher lab, with a device switcher shown for all agents in the chat input. (#15315, #15371) - `connectionId` + channel routing across the gateway client and device list; preset the local device on the first LLM request for the 本机 target. (#15322, #15435) - Run remote Claude Code on a configured device, with drag-to-reorder recent-directory management and client renders for device tool results. (#15343, #15351, #15437) - Preserve content and state across gateway tool calls, and prevent duplicate streaming from stale reconnects. (#15114, #15354) --- ## 🖥️ CLI & Desktop - Preserve content/state for connect local file and shell tools; render the `runCommand` tool result card. (#15441, #15442) - New `lh topic view` command; CLI now auto-registers its device on login, matching desktop. (#15340, #15377) - Resolve CLI tools from the shell `PATH`, and clarify local command session handling. (#15368, #15389) - Relocate visual-ref helpers to `@lobechat/const` to fix a renderer crash; upload `.blockmap` files to S3 for differential updates. (#15326, #15369) - Fix a market OAuth expiry that triggered the wrong re-login modal, and kill dev child processes on parent shutdown. (#15246, #15290) --- ## 🗂️ Pages, Library & Knowledge - Document share flow with business slot stubs, plus Workspace and Agent share tables. (#15309, #15439) - Export Agent profiles as Markdown, preserving an empty agent prompt on export. (#15312, #15316) - Editable CodeMirror viewer for local files with document highlighting; BM25 search extended to file-backed documents. (#15247, #15298) - Default new Agent-doc files to `.md` and preserve IME composition; refresh folder data on slug switch and dedupe breadcrumb fetches. (#15335, #15427) --- ## 💬 Chat & User Experience - Group-by-status mode for the Topic sidebar; dropped the legacy session→agentId compatibility path from Topic queries. (#15366, #15378) - Restore editor focus after the file picker closes, and close the skill dropdown before navigating to settings. (#15391, #15394) - Strip markdown tokens from fallback Topic titles; keep an open ActionBar popup when hovering another message. (#15303, #15372) - Stabilize home starter loading and stop transliterating model names in the home starter; show artifact source while streaming. (#15310, #15324, #15386) - Group the sidebar spacer with recents and agents. (#15373) --- ## 📊 Analytics, Tasks & Notifications - Token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup. (#15365, #15417, #15425) - Push: new `PushChannel`, receipt cron, and `pushToken` tRPC API. (#15233) - Tasks now support file and image attachments. (#15141) --- ## 🧩 Models & Providers - Support Claude Opus 4.8 and configurable model routing with starters. (#15314, #15384) - MiniMax M3: new model entry and an Anthropic video runtime. (#15380, #15403) - Add `intern-s2-preview` with `thinking_mode`, and `step-3.7-flash` support. (#15308, #15317) - Block disabling the official provider; fix default provider setup in business mode. (#15379, #15382) --- ## 🎨 UI & Modals - Migrate modals to `@lobehub/ui/base-ui` (LOBE-9711 + eval batch), including the create-custom-model and feedback/changelog modals. (#15401, #15416) - Restructure confirmModal title and content across deletion flows; polish the service-model form and migrate its Switch to base-ui. (#15426, #15440) - Wrap the BlueBubbles bridge config into a connection card; update `@lobehub/ui` to v5.15.5. (#15325, #15342) --- ## 🔒 Reliability - Replace hardcoded `session_context` values with template variables in credentials. (#15352) - Point `CHANGELOG_URL` to `/changelog`. (#15428) --- ## 👥 Contributors Huge thanks to **11 contributors** who shipped **88 merged PRs** this cycle. @hezhijie0327 · @qybaihe · @sxjeru · @arvinxx · @Innei · @tjx666 · @lijian · @sudongyuer · @cy948 · @rivertwilight · @AmAzing129 Plus @lobehubbot and renovate[bot] for maintenance. --- **Full Changelog**: v2.2.1...release/weekly-20260604
💻 Change Type
🔗 Related Issue
🔀 Description of Change
Adds a document share feature for pages and immediately extracts the commercial pieces behind business slot stubs so the cloud repo can override them.
Server / DB:
document_sharestable (packages/database/migrations/0103_add_document_shares_table.sql) withdocumentShareschema +DocumentShareModel@lobechat/types(SharedDocumentData,SharedDocumentPayload,DocumentShareVisibility,DocumentSharePermission)Business slots:
src/business/client/features/PageShare/{PageShareLayout,ReadOnlyPageViewer,ShareButton}.tsx— no-op stubssrc/business/server/lambda-routers/pageShare.ts— empty router stub, registered inrouters/lambda/index.ts_layout/index.tsx,page/[id]/index.tsx) andPageEditor/Headerconsume the slots; OSS gets no UI, cloud overrides supply the real implementationpageSharelocale namespace kept insrc/locales/default/for centralized dictionary (cloud reuses it)🧪 How to Test
OSS-only path: visit
/page/:idas a guest or owner — stubs short-circuit; routes render normally without share UI. No DB write paths execute without cloud overrides.