🐛 fix(agent-doc): default new files to .md and preserve IME composition#15427
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb5e9790d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| agentId, | ||
| content: '', | ||
| title: baseName, | ||
| title: pendingFilename, |
There was a problem hiding this comment.
Preserve .md when root create dedupes
When two root-level creates race or the local list is stale, both clients can pass the same pendingFilename here. The root path goes through agentDocumentService.createDocument, and checked createWithUniqueFilename in src/server/services/agentDocuments/index.ts: its collision fallback appends -2 to the entire filename (${baseFilename}-${suffix}), so Untitled document.md becomes Untitled document.md-2 instead of keeping the markdown extension. This means the new default .md guarantee still fails for collided root documents; use the path writer or server-side suffixing that inserts before the extension.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15427 +/- ##
==========================================
- Coverage 65.76% 65.75% -0.01%
==========================================
Files 2762 2762
Lines 256076 256104 +28
Branches 25563 32204 +6641
==========================================
+ Hits 168400 168408 +8
- Misses 87557 87577 +20
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Append `.md` to newly-created agent documents; pre-select only the stem in the inline rename input so the extension stays intact. - Wire `useIMECompositionEvent` on the explorer container so Enter pressed during IME composition (e.g. Chinese pinyin) no longer commits the half-formed name through pierre/trees' shadow-DOM input.
React `onKeyDownCapture` can lose to pierre/trees' bubble handler in some event ordering edge cases, and the original guard missed IMEs that report `keyCode === 229` or fire Enter just after compositionend in the same task. - Bind a native `keydown` capture listener on the container so we can inspect `composedPath()` and confirm the keydown originated inside the shadow-DOM rename input. - Extend the IME guard with an `imeSessionRef` that stays true through one extra microtask after compositionend. - Drop the React `onKeyDownCapture` prop in favour of the native listener.
The inline rename input lives in pierre/trees' shadow DOM and we can't reliably suppress its IME-composing Enter commit from the outside. Roll back the local hack and track the issue upstream instead. The default `.md` extension and stem-only selection on rename stay in place.
Existing files entering inline rename (right-click → Rename, or F2) now narrow the selection to the stem after pierre/trees' `input.select()`, matching the new-file flow so the user never has to retype `.md`.
9f27b21 to
5e32495
Compare
# 🚀 LobeHub Release (20260604) **Release Date:** June 4, 2026 **Since v2.2.1:** 88 merged PRs · 11 contributors > This week brings Execution Devices out of the lab — run agents and Claude Code on any configured local or remote machine — alongside Claude Opus 4.8, token-usage analytics, and Page sharing. --- ## ✨ Highlights - **Execution Devices** — Pick where an agent runs. Desktop and CLI devices auto-register with a stable machine ID, route through the gateway by channel, and surface a device switcher in the chat input. Run remote Claude Code on a configured device, with a recent-directory picker you can drag to reorder. (#15300, #15315, #15322, #15343, #15351, #15371) - **Claude Opus 4.8** — Day-one support for Anthropic's latest model. (#15314) - **Token-usage analytics** — A new token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup so totals stay accurate without recomputing from messages. (#15365, #15417, #15425) - **Page sharing** — Share a Page through a dedicated document share flow, plus new Workspace and Agent share tables. (#15309, #15439) - **Self-iteration agents** — Agent Signal's execAgent migration lands a server-runtime bridge, async memory writer, and a registered self-iteration tool package, with a CLI trigger command for testing. (#15360, #15364, #15392) - **Knowledge search** — BM25 search now extends to file-backed documents, and the portal ships an editable CodeMirror viewer for local files with document highlighting. (#15247, #15298) --- ## 🏗️ Core Agent & Architecture ### Agent Signal & Runtime - **execAgent migration** — Server-runtime bridge, completion projection, async memory writer, and removal of the legacy `executeSelfIteration` path. (#15392) - Registered the self-iteration builtin tool package and restored the three mode-specific self-iteration agent slugs. (#15202, #15364) - Added a CLI trigger command with a golden-snapshot fixture for Agent Signal. (#15360) - **Skill priority** — Agent Builder now emits a skill-priority instruction with matching server runtime. (#15409) - Retry empty LLM completions instead of silently finishing the turn. (#15355) - Classify topic/agent/session foreign-key violations as `ConversationParentMissing` for clearer recovery. (#15408) - Persist canonical nested usage/performance on assistant messages, and re-link orphan tool messages at the raw bucket write boundary. (#15359, #15438) - Guard `createAgent` against LLM double-encoded array fields. (#15381) --- ## 🖥️ Execution Devices & Gateway - Auto-register desktop and CLI devices with a stable machine ID, and add the `@lobechat/device-identity` package. (#15300, #15321) - New Devices settings page behind the Execution Device Switcher lab, with a device switcher shown for all agents in the chat input. (#15315, #15371) - `connectionId` + channel routing across the gateway client and device list; preset the local device on the first LLM request for the 本机 target. (#15322, #15435) - Run remote Claude Code on a configured device, with drag-to-reorder recent-directory management and client renders for device tool results. (#15343, #15351, #15437) - Preserve content and state across gateway tool calls, and prevent duplicate streaming from stale reconnects. (#15114, #15354) --- ## 🖥️ CLI & Desktop - Preserve content/state for connect local file and shell tools; render the `runCommand` tool result card. (#15441, #15442) - New `lh topic view` command; CLI now auto-registers its device on login, matching desktop. (#15340, #15377) - Resolve CLI tools from the shell `PATH`, and clarify local command session handling. (#15368, #15389) - Relocate visual-ref helpers to `@lobechat/const` to fix a renderer crash; upload `.blockmap` files to S3 for differential updates. (#15326, #15369) - Fix a market OAuth expiry that triggered the wrong re-login modal, and kill dev child processes on parent shutdown. (#15246, #15290) --- ## 🗂️ Pages, Library & Knowledge - Document share flow with business slot stubs, plus Workspace and Agent share tables. (#15309, #15439) - Export Agent profiles as Markdown, preserving an empty agent prompt on export. (#15312, #15316) - Editable CodeMirror viewer for local files with document highlighting; BM25 search extended to file-backed documents. (#15247, #15298) - Default new Agent-doc files to `.md` and preserve IME composition; refresh folder data on slug switch and dedupe breadcrumb fetches. (#15335, #15427) --- ## 💬 Chat & User Experience - Group-by-status mode for the Topic sidebar; dropped the legacy session→agentId compatibility path from Topic queries. (#15366, #15378) - Restore editor focus after the file picker closes, and close the skill dropdown before navigating to settings. (#15391, #15394) - Strip markdown tokens from fallback Topic titles; keep an open ActionBar popup when hovering another message. (#15303, #15372) - Stabilize home starter loading and stop transliterating model names in the home starter; show artifact source while streaming. (#15310, #15324, #15386) - Group the sidebar spacer with recents and agents. (#15373) --- ## 📊 Analytics, Tasks & Notifications - Token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup. (#15365, #15417, #15425) - Push: new `PushChannel`, receipt cron, and `pushToken` tRPC API. (#15233) - Tasks now support file and image attachments. (#15141) --- ## 🧩 Models & Providers - Support Claude Opus 4.8 and configurable model routing with starters. (#15314, #15384) - MiniMax M3: new model entry and an Anthropic video runtime. (#15380, #15403) - Add `intern-s2-preview` with `thinking_mode`, and `step-3.7-flash` support. (#15308, #15317) - Block disabling the official provider; fix default provider setup in business mode. (#15379, #15382) --- ## 🎨 UI & Modals - Migrate modals to `@lobehub/ui/base-ui` (LOBE-9711 + eval batch), including the create-custom-model and feedback/changelog modals. (#15401, #15416) - Restructure confirmModal title and content across deletion flows; polish the service-model form and migrate its Switch to base-ui. (#15426, #15440) - Wrap the BlueBubbles bridge config into a connection card; update `@lobehub/ui` to v5.15.5. (#15325, #15342) --- ## 🔒 Reliability - Replace hardcoded `session_context` values with template variables in credentials. (#15352) - Point `CHANGELOG_URL` to `/changelog`. (#15428) --- ## 👥 Contributors Huge thanks to **11 contributors** who shipped **88 merged PRs** this cycle. @hezhijie0327 · @qybaihe · @sxjeru · @arvinxx · @Innei · @tjx666 · @lijian · @sudongyuer · @cy948 · @rivertwilight · @AmAzing129 Plus @lobehubbot and renovate[bot] for maintenance. --- **Full Changelog**: v2.2.1...release/weekly-20260604
💻 Change Type
🔗 Related Issue
🔀 Description of Change
Two small UX fixes for the agent document explorer's inline file creation:
.mdextension on new documents.useDocumentTreeOps.createDocumentnow appends.mdto the picked filename (e.g.Untitled document.md, with the numeric dedup suffix inserted before the extension asUntitled document 2.md). At the tree root the client-picked filename is forwarded as the title toagentDocumentService.createDocumentso the server keeps the.mdsuffix end-to-end.startRenaming, we reach into thefile-tree-containershadow DOM and callsetSelectionRange(0, lastDotIndex)oninput[data-item-rename-input]so the user can type a new name without overwriting.md. Dotfiles and extension-less names fall through to pierre/trees' default full-selection.@pierre/trees' inline rename input lives in a shadow root and itshandleTreeKeyDowncommits the rename on everyEnterkeydown without checkingevent.isComposing/keyCode === 229(node_modules/@pierre/trees/dist/render/FileTreeView.js:1110-1118). When a Chinese-pinyin / Japanese / Korean candidate is confirmed via Enter, the rename commits the half-formed input instead of the intended character.We explored intercepting from outside the shadow boundary (React
onKeyDownCaptureand a nativeaddEventListener('keydown', …, true)on the host withcomposedPath()scoping). It works for the common path but fails on edge cases where the IME emitsEnterkeydown withisComposing: falseright aftercompositionendin the same task — there is no reliable purely-external fix. The IME guard has been reverted in this PR; the proper fix needs to land in@pierre/trees.Upstream issue filed: pierrecomputer/pierre#773 — we'll follow up here once it's released.
🧪 How to Test
Steps:
Untitled document.mdwith onlyUntitled documentselected in the rename input.Untitled document.md.Untitled document 2.md.📸 Screenshots / Videos
Untitled document.mdwith stem-only selection.📝 Additional Information
No schema changes, no migrations, no API surface changes. The shadow-DOM
querySelectoris scoped to the explorer container'sfile-tree-containerhost, so it can't reach unrelated pierre trees on the page.