✨ feat(agent-signal): register self-iteration builtin tool package#15364
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e5b02b605
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| discoverable: false, | ||
| hidden: true, | ||
| identifier: agentSignalReviewManifest.identifier, | ||
| manifest: agentSignalReviewManifest, | ||
| type: 'builtin', |
There was a problem hiding this comment.
Register matching server runtimes for agent-signal tools
Registering these manifests in the global builtin list makes the agent-signal-review/reflection/feedback-intent plugins available to the builtin agents, but there is no matching entry in src/server/services/toolExecution/serverRuntimes/index.ts (the registry still only includes the legacy lobe-self-feedback-intent runtime). When a nightly-review or self-reflection agent calls any of these server-executed APIs, BuiltinToolsExecutor will hit hasServerRuntime(identifier) === false and throw Builtin tool "agent-signal-review" is not implemented instead of executing the tool, so the newly exposed tool surface is unusable until these identifiers are wired to a server runtime.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #15364 +/- ##
=========================================
Coverage 71.15% 71.15%
=========================================
Files 3200 3200
Lines 319698 319698
Branches 28212 34932 +6720
=========================================
Hits 227487 227487
Misses 92039 92039
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Part of LOBE-9434 (#3). Gives the three (currently dormant) self-iteration builtin agents a declarative tool surface so they no longer run with no tools. One package `@lobechat/builtin-tool-agent-signal` with internal subdirs: - `shared/`: the 3 stable identifiers, JSON-schema specs for the full tool surface (resource / review / reflection), a result-kind map (read | artifact | mutation — the LOBE-9434 #5 discriminator), `createAgentSignalManifest`, and one shared `AgentSignalToolExecutionRuntime` that dispatches per api name and stamps every result with its kind so `extractFromFinalState` can partition outcomes from a persisted snapshot. - `review/` `reflection/` `feedback-intent/`: per-mode manifests assembled from the shared specs + a mode-specific system prompt, exported under their three stable identifiers. Review = resource + proposal/idea tools; reflection & feedback-intent share the resource + reflection-recorder surface. Registered all three manifests in `@lobechat/builtin-tools`. `executors` is omitted on purpose — BuiltinToolManifest defaults to server-only execution. The server-side execution bridge (wiring the ExecutionRuntime to the existing createToolSet(adapters) from ToolExecutionContext) lands with the executeSelfIteration -> execAgent migration (#7); the ExecutionRuntime is exported (./executionRuntime) and ready for it. No production self-iteration path is touched — executeSelfIteration still serves all current runs. Tested: shared ExecutionRuntime (dispatch + kind stamping + error handling) and review manifest structure. bun run type-check clean for everything touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
5e5b02b to
eee7638
Compare
# 🚀 LobeHub Release (20260604) **Release Date:** June 4, 2026 **Since v2.2.1:** 88 merged PRs · 11 contributors > This week brings Execution Devices out of the lab — run agents and Claude Code on any configured local or remote machine — alongside Claude Opus 4.8, token-usage analytics, and Page sharing. --- ## ✨ Highlights - **Execution Devices** — Pick where an agent runs. Desktop and CLI devices auto-register with a stable machine ID, route through the gateway by channel, and surface a device switcher in the chat input. Run remote Claude Code on a configured device, with a recent-directory picker you can drag to reorder. (#15300, #15315, #15322, #15343, #15351, #15371) - **Claude Opus 4.8** — Day-one support for Anthropic's latest model. (#15314) - **Token-usage analytics** — A new token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup so totals stay accurate without recomputing from messages. (#15365, #15417, #15425) - **Page sharing** — Share a Page through a dedicated document share flow, plus new Workspace and Agent share tables. (#15309, #15439) - **Self-iteration agents** — Agent Signal's execAgent migration lands a server-runtime bridge, async memory writer, and a registered self-iteration tool package, with a CLI trigger command for testing. (#15360, #15364, #15392) - **Knowledge search** — BM25 search now extends to file-backed documents, and the portal ships an editable CodeMirror viewer for local files with document highlighting. (#15247, #15298) --- ## 🏗️ Core Agent & Architecture ### Agent Signal & Runtime - **execAgent migration** — Server-runtime bridge, completion projection, async memory writer, and removal of the legacy `executeSelfIteration` path. (#15392) - Registered the self-iteration builtin tool package and restored the three mode-specific self-iteration agent slugs. (#15202, #15364) - Added a CLI trigger command with a golden-snapshot fixture for Agent Signal. (#15360) - **Skill priority** — Agent Builder now emits a skill-priority instruction with matching server runtime. (#15409) - Retry empty LLM completions instead of silently finishing the turn. (#15355) - Classify topic/agent/session foreign-key violations as `ConversationParentMissing` for clearer recovery. (#15408) - Persist canonical nested usage/performance on assistant messages, and re-link orphan tool messages at the raw bucket write boundary. (#15359, #15438) - Guard `createAgent` against LLM double-encoded array fields. (#15381) --- ## 🖥️ Execution Devices & Gateway - Auto-register desktop and CLI devices with a stable machine ID, and add the `@lobechat/device-identity` package. (#15300, #15321) - New Devices settings page behind the Execution Device Switcher lab, with a device switcher shown for all agents in the chat input. (#15315, #15371) - `connectionId` + channel routing across the gateway client and device list; preset the local device on the first LLM request for the 本机 target. (#15322, #15435) - Run remote Claude Code on a configured device, with drag-to-reorder recent-directory management and client renders for device tool results. (#15343, #15351, #15437) - Preserve content and state across gateway tool calls, and prevent duplicate streaming from stale reconnects. (#15114, #15354) --- ## 🖥️ CLI & Desktop - Preserve content/state for connect local file and shell tools; render the `runCommand` tool result card. (#15441, #15442) - New `lh topic view` command; CLI now auto-registers its device on login, matching desktop. (#15340, #15377) - Resolve CLI tools from the shell `PATH`, and clarify local command session handling. (#15368, #15389) - Relocate visual-ref helpers to `@lobechat/const` to fix a renderer crash; upload `.blockmap` files to S3 for differential updates. (#15326, #15369) - Fix a market OAuth expiry that triggered the wrong re-login modal, and kill dev child processes on parent shutdown. (#15246, #15290) --- ## 🗂️ Pages, Library & Knowledge - Document share flow with business slot stubs, plus Workspace and Agent share tables. (#15309, #15439) - Export Agent profiles as Markdown, preserving an empty agent prompt on export. (#15312, #15316) - Editable CodeMirror viewer for local files with document highlighting; BM25 search extended to file-backed documents. (#15247, #15298) - Default new Agent-doc files to `.md` and preserve IME composition; refresh folder data on slug switch and dedupe breadcrumb fetches. (#15335, #15427) --- ## 💬 Chat & User Experience - Group-by-status mode for the Topic sidebar; dropped the legacy session→agentId compatibility path from Topic queries. (#15366, #15378) - Restore editor focus after the file picker closes, and close the skill dropdown before navigating to settings. (#15391, #15394) - Strip markdown tokens from fallback Topic titles; keep an open ActionBar popup when hovering another message. (#15303, #15372) - Stabilize home starter loading and stop transliterating model names in the home starter; show artifact source while streaming. (#15310, #15324, #15386) - Group the sidebar spacer with recents and agents. (#15373) --- ## 📊 Analytics, Tasks & Notifications - Token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup. (#15365, #15417, #15425) - Push: new `PushChannel`, receipt cron, and `pushToken` tRPC API. (#15233) - Tasks now support file and image attachments. (#15141) --- ## 🧩 Models & Providers - Support Claude Opus 4.8 and configurable model routing with starters. (#15314, #15384) - MiniMax M3: new model entry and an Anthropic video runtime. (#15380, #15403) - Add `intern-s2-preview` with `thinking_mode`, and `step-3.7-flash` support. (#15308, #15317) - Block disabling the official provider; fix default provider setup in business mode. (#15379, #15382) --- ## 🎨 UI & Modals - Migrate modals to `@lobehub/ui/base-ui` (LOBE-9711 + eval batch), including the create-custom-model and feedback/changelog modals. (#15401, #15416) - Restructure confirmModal title and content across deletion flows; polish the service-model form and migrate its Switch to base-ui. (#15426, #15440) - Wrap the BlueBubbles bridge config into a connection card; update `@lobehub/ui` to v5.15.5. (#15325, #15342) --- ## 🔒 Reliability - Replace hardcoded `session_context` values with template variables in credentials. (#15352) - Point `CHANGELOG_URL` to `/changelog`. (#15428) --- ## 👥 Contributors Huge thanks to **11 contributors** who shipped **88 merged PRs** this cycle. @hezhijie0327 · @qybaihe · @sxjeru · @arvinxx · @Innei · @tjx666 · @lijian · @sudongyuer · @cy948 · @rivertwilight · @AmAzing129 Plus @lobehubbot and renovate[bot] for maintenance. --- **Full Changelog**: v2.2.1...release/weekly-20260604
💻 Change Type
🔗 Related Issue
Part of LOBE-9434 (#3). Follows #15202 (the 3-slug agent split). Gives the three currently-dormant self-iteration builtin agents (
nightly-review/self-reflection/self-feedback-intent) a declarative tool surface so they no longer run with no tools.🔀 Description of Change
#15202 restored the 3 mode-specific agent slugs but left them dormant — their
plugins: ['agent-signal-{review,reflection,feedback-intent}']referenced a tool surface that didn't exist. This PR provides it.One package
@lobechat/builtin-tool-agent-signalwith internal subdirs (the 3 manifests share ~90% of their surface and are never used independently, so a single package with mode subdirs beats 4 split packages):shared/— the 3 stable identifiers; JSON-schema specs for the full tool surface (resource / review / reflection), faithful to the legacycreateToolManifest(mode); a result-kind map (read | artifact | mutation, the LOBE-9434 build(deps-dev): bump prettier from 2.8.8 to 3.0.0 #5 discriminator);createAgentSignalManifest; and one sharedAgentSignalToolExecutionRuntimethat builds one bound method per api name (theBuiltinToolsExecutordispatchesruntime[apiName](args, ctx)), delegates to an injected service, and stamps every result with itskindsoextractFromFinalStatecan partition outcomes from a snapshot.review/reflection/feedback-intent/— per-mode manifests assembled from the shared specs + a mode-specific system prompt, exported under their three stable identifiers. Review = resource + proposal/idea tools (13); reflection & feedback-intent share the resource + reflection-recorder surface (8) under distinct identifiers.Registry: all three manifests registered in
@lobechat/builtin-tools(index.ts+identifiers.ts+ one workspace dep).executorsis omitted —BuiltinToolManifestdefaults to server-only execution, which is exactly what these background tools need.executeSelfIterationstill serves every current self-iteration run; nothing invokes these manifests yet.ExecutionRuntimeto the existingcreateToolSet(adapters)viaToolExecutionContext(aserverRuntimes/*factory) — lands with theexecuteSelfIteration → execAgentmigration (Chat v0.1 #7). TheExecutionRuntimeis exported (./executionRuntime) and ready for it.kindschema where it's most natural (the package tool-result shape).🧪 How to Test
bun run type-checkclean for everything touched (the only remaining errors are pre-existing inpackages/business/model-runtime, unrelated).📝 Additional Information
Cloud impact: none.
🤖 Generated with Claude Code