✨ feat(portal): editable CodeMirror viewer for LocalFile + Document highlight#15298
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 755a9cf1d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| value={editingValue} | ||
| onChange={handleCodeChange} | ||
| onSave={handleSave} |
There was a problem hiding this comment.
Prevent saving truncated previews
When a local text file exceeds MAX_PREVIEW_CHARS, ActiveFileView passes only the sliced prefix as content, and this editable pane derives editingValue from that prefix. If the user changes anything and presses Cmd/Ctrl+S, saveLocalFile writes this partial string back as the whole file, dropping everything after the first 500,000 characters. Please disable editing/saving for truncated previews or save against the full file content.
Useful? React with 👍 / 👎.
| await localFileService.writeFile({ content: buffer, path: filePath }); | ||
| return buffer; |
There was a problem hiding this comment.
Check writeFile failures before clearing dirty state
In the desktop path, handleWriteFile returns { success: false, error } for validation or disk-write failures rather than throwing, so this await can complete even though nothing was written. saveLocalFile then returns the buffer as if it was saved, and the caller clears the dirty buffer/SWR state, losing the user's unsaved changes on cases like disk-full or permission errors. Please inspect the result and throw or return undefined unless success is true.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15298 +/- ##
==========================================
- Coverage 71.13% 71.12% -0.01%
==========================================
Files 3176 3176
Lines 317514 317606 +92
Branches 34656 28917 -5739
==========================================
+ Hits 225851 225900 +49
- Misses 91491 91534 +43
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ighlight
Replace the read-only Highlighter in the LocalFile portal preview and the
Document portal highlight mode with a shared `CodeEditorPane` powered by
`@lobehub/editor/codemirror`. Pane supports inline editing, Cmd/Ctrl+S to
save, lobeTheme tokens, and language-aware syntax highlighting.
LocalFile flow
- Track per-path edit buffers + save action in the chat portal store
(`dirtyLocalFileContents`, `setLocalFileBuffer`, `saveLocalFile`).
- Show a filled dot on the tab close button when the file is dirty;
hovering still reveals the X. Closing a dirty tab (via X or the context
menu's "Close") prompts a confirmation modal via `confirmModal` from
`@lobehub/ui/base-ui`.
- After save, mutate the SWR cache to the just-saved content before
clearing the buffer so CodeMirror does not see a stale `value` prop and
reset the cursor.
Document flow
- For non-markdown documents (`getDocumentRenderMode` → `highlight`),
render `CodeEditorPane` with a local edit buffer keyed by `documentId`.
- Save calls `documentService.updateDocument({ saveSource: 'manual' })`,
mutates the document-meta SWR cache, then clears the buffer.
Bump `@lobehub/editor` to ^4.15.0 to pick up the new
`@lobehub/editor/codemirror` subpath export.
When a file exceeds MAX_PREVIEW_CHARS the preview only holds the first
500k character prefix. Editing and saving against that prefix would
silently overwrite the rest of the file with the truncated content.
Pass `readOnly={truncated}` to the editor, ignore any stale buffer when
truncated, and short-circuit handleSave so Cmd/Ctrl+S is a no-op in this
mode.
Always pass the full file content to the editor instead of slicing at 500k characters. The truncation existed only to avoid losing data when saving the previously-Highlighter-rendered prefix, but with full content available the editor can both display and persist the file safely. Removes the `truncated` / `truncatedLabel` plumbing, the truncated banner, and the associated read-only short-circuit in handleSave.
4d47842 to
134652d
Compare
…ighlight (lobehub#15298) * ✨ feat(portal): editable CodeMirror viewer for LocalFile + Document highlight Replace the read-only Highlighter in the LocalFile portal preview and the Document portal highlight mode with a shared `CodeEditorPane` powered by `@lobehub/editor/codemirror`. Pane supports inline editing, Cmd/Ctrl+S to save, lobeTheme tokens, and language-aware syntax highlighting. LocalFile flow - Track per-path edit buffers + save action in the chat portal store (`dirtyLocalFileContents`, `setLocalFileBuffer`, `saveLocalFile`). - Show a filled dot on the tab close button when the file is dirty; hovering still reveals the X. Closing a dirty tab (via X or the context menu's "Close") prompts a confirmation modal via `confirmModal` from `@lobehub/ui/base-ui`. - After save, mutate the SWR cache to the just-saved content before clearing the buffer so CodeMirror does not see a stale `value` prop and reset the cursor. Document flow - For non-markdown documents (`getDocumentRenderMode` → `highlight`), render `CodeEditorPane` with a local edit buffer keyed by `documentId`. - Save calls `documentService.updateDocument({ saveSource: 'manual' })`, mutates the document-meta SWR cache, then clears the buffer. Bump `@lobehub/editor` to ^4.15.0 to pick up the new `@lobehub/editor/codemirror` subpath export. * 🐛 fix(portal): force read-only on truncated local file previews When a file exceeds MAX_PREVIEW_CHARS the preview only holds the first 500k character prefix. Editing and saving against that prefix would silently overwrite the rest of the file with the truncated content. Pass `readOnly={truncated}` to the editor, ignore any stale buffer when truncated, and short-circuit handleSave so Cmd/Ctrl+S is a no-op in this mode. * ♻️ refactor(portal): drop MAX_PREVIEW_CHARS truncation for local files Always pass the full file content to the editor instead of slicing at 500k characters. The truncation existed only to avoid losing data when saving the previously-Highlighter-rendered prefix, but with full content available the editor can both display and persist the file safely. Removes the `truncated` / `truncatedLabel` plumbing, the truncated banner, and the associated read-only short-circuit in handleSave. * ✅ test(portal): update document body highlight editor test
# 🚀 LobeHub Release (20260604) **Release Date:** June 4, 2026 **Since v2.2.1:** 88 merged PRs · 11 contributors > This week brings Execution Devices out of the lab — run agents and Claude Code on any configured local or remote machine — alongside Claude Opus 4.8, token-usage analytics, and Page sharing. --- ## ✨ Highlights - **Execution Devices** — Pick where an agent runs. Desktop and CLI devices auto-register with a stable machine ID, route through the gateway by channel, and surface a device switcher in the chat input. Run remote Claude Code on a configured device, with a recent-directory picker you can drag to reorder. (#15300, #15315, #15322, #15343, #15351, #15371) - **Claude Opus 4.8** — Day-one support for Anthropic's latest model. (#15314) - **Token-usage analytics** — A new token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup so totals stay accurate without recomputing from messages. (#15365, #15417, #15425) - **Page sharing** — Share a Page through a dedicated document share flow, plus new Workspace and Agent share tables. (#15309, #15439) - **Self-iteration agents** — Agent Signal's execAgent migration lands a server-runtime bridge, async memory writer, and a registered self-iteration tool package, with a CLI trigger command for testing. (#15360, #15364, #15392) - **Knowledge search** — BM25 search now extends to file-backed documents, and the portal ships an editable CodeMirror viewer for local files with document highlighting. (#15247, #15298) --- ## 🏗️ Core Agent & Architecture ### Agent Signal & Runtime - **execAgent migration** — Server-runtime bridge, completion projection, async memory writer, and removal of the legacy `executeSelfIteration` path. (#15392) - Registered the self-iteration builtin tool package and restored the three mode-specific self-iteration agent slugs. (#15202, #15364) - Added a CLI trigger command with a golden-snapshot fixture for Agent Signal. (#15360) - **Skill priority** — Agent Builder now emits a skill-priority instruction with matching server runtime. (#15409) - Retry empty LLM completions instead of silently finishing the turn. (#15355) - Classify topic/agent/session foreign-key violations as `ConversationParentMissing` for clearer recovery. (#15408) - Persist canonical nested usage/performance on assistant messages, and re-link orphan tool messages at the raw bucket write boundary. (#15359, #15438) - Guard `createAgent` against LLM double-encoded array fields. (#15381) --- ## 🖥️ Execution Devices & Gateway - Auto-register desktop and CLI devices with a stable machine ID, and add the `@lobechat/device-identity` package. (#15300, #15321) - New Devices settings page behind the Execution Device Switcher lab, with a device switcher shown for all agents in the chat input. (#15315, #15371) - `connectionId` + channel routing across the gateway client and device list; preset the local device on the first LLM request for the 本机 target. (#15322, #15435) - Run remote Claude Code on a configured device, with drag-to-reorder recent-directory management and client renders for device tool results. (#15343, #15351, #15437) - Preserve content and state across gateway tool calls, and prevent duplicate streaming from stale reconnects. (#15114, #15354) --- ## 🖥️ CLI & Desktop - Preserve content/state for connect local file and shell tools; render the `runCommand` tool result card. (#15441, #15442) - New `lh topic view` command; CLI now auto-registers its device on login, matching desktop. (#15340, #15377) - Resolve CLI tools from the shell `PATH`, and clarify local command session handling. (#15368, #15389) - Relocate visual-ref helpers to `@lobechat/const` to fix a renderer crash; upload `.blockmap` files to S3 for differential updates. (#15326, #15369) - Fix a market OAuth expiry that triggered the wrong re-login modal, and kill dev child processes on parent shutdown. (#15246, #15290) --- ## 🗂️ Pages, Library & Knowledge - Document share flow with business slot stubs, plus Workspace and Agent share tables. (#15309, #15439) - Export Agent profiles as Markdown, preserving an empty agent prompt on export. (#15312, #15316) - Editable CodeMirror viewer for local files with document highlighting; BM25 search extended to file-backed documents. (#15247, #15298) - Default new Agent-doc files to `.md` and preserve IME composition; refresh folder data on slug switch and dedupe breadcrumb fetches. (#15335, #15427) --- ## 💬 Chat & User Experience - Group-by-status mode for the Topic sidebar; dropped the legacy session→agentId compatibility path from Topic queries. (#15366, #15378) - Restore editor focus after the file picker closes, and close the skill dropdown before navigating to settings. (#15391, #15394) - Strip markdown tokens from fallback Topic titles; keep an open ActionBar popup when hovering another message. (#15303, #15372) - Stabilize home starter loading and stop transliterating model names in the home starter; show artifact source while streaming. (#15310, #15324, #15386) - Group the sidebar spacer with recents and agents. (#15373) --- ## 📊 Analytics, Tasks & Notifications - Token-usage mode on the activity heatmap, backed by a denormalized topic usage/cost rollup. (#15365, #15417, #15425) - Push: new `PushChannel`, receipt cron, and `pushToken` tRPC API. (#15233) - Tasks now support file and image attachments. (#15141) --- ## 🧩 Models & Providers - Support Claude Opus 4.8 and configurable model routing with starters. (#15314, #15384) - MiniMax M3: new model entry and an Anthropic video runtime. (#15380, #15403) - Add `intern-s2-preview` with `thinking_mode`, and `step-3.7-flash` support. (#15308, #15317) - Block disabling the official provider; fix default provider setup in business mode. (#15379, #15382) --- ## 🎨 UI & Modals - Migrate modals to `@lobehub/ui/base-ui` (LOBE-9711 + eval batch), including the create-custom-model and feedback/changelog modals. (#15401, #15416) - Restructure confirmModal title and content across deletion flows; polish the service-model form and migrate its Switch to base-ui. (#15426, #15440) - Wrap the BlueBubbles bridge config into a connection card; update `@lobehub/ui` to v5.15.5. (#15325, #15342) --- ## 🔒 Reliability - Replace hardcoded `session_context` values with template variables in credentials. (#15352) - Point `CHANGELOG_URL` to `/changelog`. (#15428) --- ## 👥 Contributors Huge thanks to **11 contributors** who shipped **88 merged PRs** this cycle. @hezhijie0327 · @qybaihe · @sxjeru · @arvinxx · @Innei · @tjx666 · @lijian · @sudongyuer · @cy948 · @rivertwilight · @AmAzing129 Plus @lobehubbot and renovate[bot] for maintenance. --- **Full Changelog**: v2.2.1...release/weekly-20260604
Summary
Replace the read-only
Highlighterin the LocalFile portal preview and the Document portal highlight mode with a sharedCodeEditorPanepowered by@lobehub/editor/codemirror. The pane supports inline editing, Cmd/Ctrl+S to save, lobeTheme tokens, and language-aware syntax highlighting.LocalFile
dirtyLocalFileContents,setLocalFileBuffer,saveLocalFile).confirmModalfrom@lobehub/ui/base-ui.valueprop and reset the cursor.Document
getDocumentRenderMode→highlight), renderCodeEditorPanewith a local edit buffer keyed bydocumentIdso switching documents re-mounts the editor.documentService.updateDocument({ saveSource: 'manual' }), mutates the document-meta SWR cache, then clears the buffer.Dependency
Bump
@lobehub/editorto^4.15.0to pick up the new@lobehub/editor/codemirrorsubpath export.Test plan
pnpm lint/tsc --noEmiton touched filesdocumentService.updateDocument, cursor stays put after saveEditorCanvas)