Skip to content

✨ feat(push): add PushChannel, receipt cron, and pushToken tRPC API#15233

Merged
sudongyuer merged 1 commit into
canaryfrom
sudongyuer/push-business-layer
May 31, 2026
Merged

✨ feat(push): add PushChannel, receipt cron, and pushToken tRPC API#15233
sudongyuer merged 1 commit into
canaryfrom
sudongyuer/push-business-layer

Conversation

@sudongyuer

@sudongyuer sudongyuer commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Send-side machinery for mobile push notifications (LOBE-8771). The schema portion (table + migration) was already merged via #15280; this PR adds the PushTokenModel on top of that schema, plus the send-side stack.

Linear: LOBE-8771 · LOBE-9138
Companion PRs:

What's included

Model

  • PushTokenModel with idempotent upsert (onConflictDoUpdate on (user_id, device_id)), scoped unregister(deviceId), listByUserId().
  • Static deletePushTokensByExpoTokens helper used by the receipt-cleanup worker (cross-user delete by Expo token, needed when Expo returns DeviceNotRegistered).

tRPC API

  • pushToken.register({ expoToken, deviceId, platform, appVersion?, locale? })
  • pushToken.unregister({ deviceId })
  • Exposed on both MobileRouter and LambdaRouter.

PushChannel

  • Structurally compatible with cloud's NotificationChannel interface — drops in without casts.
  • Fans a single notification out to all of a user's tokens, chunks via expo-server-sdk.
  • Respects Expo's 600 msg/sec project limit (100ms throttle between chunks).
  • Embeds (ticketId, expoToken) pairs in providerMessageId for receipt reconciliation.
  • Returns no_tokens / invalid_tokens / rate_limited / all_send_failed so callers can distinguish.
  • Rethrows non-429 send errors so NotificationService can log + retry.

processPushReceipts

  • Pure helper for cloud's Vercel cron (companion cloud PR registers it at /cron/process-push-receipts).
  • Polls Expo receipts in parallel (Promise.all across chunks), updates notification_deliveries in bulk, prunes push_tokens rows flagged DeviceNotRegistered.
  • Configurable lookback window + min-age guard (default: [24h ago, 15min ago]).
  • Dedupes invalid tokens across deliveries before deleting.

Dev tooling

  • /api/dev/test-push (404s in production) lets you fire a real push directly to a user's registered tokens, bypassing NotificationService. Used for E2E verification.

Types

  • NotificationSettings gains an optional push channel (used by userSettings.notification.push per-user preference).

Architecture note

The setup uses opt-in scenarios. By default no scenario sends push — the cloud-side PR will explicitly add 'push' to image_generation_completed and video_generation_completed's channels arrays. User preferences sit on top, giving a per-channel and per-type kill switch.

Test plan

  • 10 model tests — upsert conflict, multi-device, cascade delete, scoped unregister, deletePushTokensByExpoTokens cross-user behavior, empty-array noop
  • 7 router tests — zod validation, mutation passthrough
  • 7 PushChannel tests — no_tokens / invalid_tokens / single-send-error / all_send_failed / rate_limited / 429 / non-429 rethrow
  • 7 processPushReceipts tests — empty pending, all-ok delivery, mixed DeviceNotRegistered, error aggregation, no-yet-receipts (leave in sent), malformed providerMessageId skip, cross-delivery dedupe
  • type-check, lint clean
  • iOS real-device E2E — pushToken.register writes push_tokens row, dev /test-push delivers to locked iPhone via APNs, deep link cold-start nav verified

🤖 Generated with Claude Code

@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: lobehub.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 26, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @sudongyuer, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@dosubot dosubot Bot added the platform:mobile Mobile app label May 26, 2026
@sudongyuer sudongyuer changed the base branch from canary to sudongyuer/addis-ababa-v1 May 26, 2026 03:35
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 26, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

if (outcomes.every((o) => o === undefined)) continue;
const errors = outcomes.filter((o) => o?.status === 'error');
if (errors.length === 0) {
updateTasks.push(

P1 Badge Wait for all ticket receipts before marking delivery delivered

This marks a delivery as delivered whenever there are no explicit errors, but it does not require that every ticket has a receipt yet. In mixed states (some tickets ok, others still missing), errors.length === 0 is true and the delivery is finalized too early, so later error receipts (e.g. DeviceNotRegistered) are never processed and invalid tokens are not cleaned up for that delivery.



P2 Badge Make migration statements idempotent

This migration uses plain CREATE TABLE/INDEX and ALTER TABLE ... ADD CONSTRAINT without IF NOT EXISTS / IF EXISTS guards, unlike the repository’s recent migration pattern. Re-running migrations on an environment that already has these objects will fail with duplicate-object errors and stop rollout or recovery workflows.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.26962% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.15%. Comparing base (e4d5017) to head (a4c3e20).
⚠️ Report is 6 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #15233      +/-   ##
==========================================
+ Coverage   71.11%   71.15%   +0.03%     
==========================================
  Files        3188     3194       +6     
  Lines      318686   319059     +373     
  Branches    34769    33904     -865     
==========================================
+ Hits       226638   227011     +373     
  Misses      91876    91876              
  Partials      172      172              
Flag Coverage Δ
app 62.00% <96.81%> (+0.05%) ⬆️
database 92.41% <100.00%> (+0.02%) ⬆️
packages/agent-runtime 80.48% <ø> (ø)
packages/builtin-tool-lobe-agent 18.52% <ø> (ø)
packages/context-engine 84.17% <ø> (ø)
packages/conversation-flow 91.29% <ø> (ø)
packages/file-loaders 87.89% <ø> (ø)
packages/memory-user-memory 74.99% <ø> (ø)
packages/model-bank 99.99% <ø> (ø)
packages/model-runtime 84.71% <ø> (+<0.01%) ⬆️
packages/prompts 72.68% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 35.90% <ø> (+0.03%) ⬆️
packages/utils 88.47% <ø> (ø)
packages/web-crawler 88.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 68.44% <ø> (ø)
Services 54.61% <25.00%> (-0.04%) ⬇️
Server 72.46% <97.14%> (+0.10%) ⬆️
Libs 57.01% <ø> (ø)
Utils 81.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudongyuer sudongyuer force-pushed the sudongyuer/push-business-layer branch from 63649b9 to f8513d7 Compare May 31, 2026 16:10
@sudongyuer sudongyuer changed the base branch from sudongyuer/addis-ababa-v1 to canary May 31, 2026 16:10
@sudongyuer sudongyuer force-pushed the sudongyuer/push-business-layer branch from f8513d7 to 25bcf9b Compare May 31, 2026 16:11
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 31, 2026
@sudongyuer sudongyuer force-pushed the sudongyuer/push-business-layer branch from 25bcf9b to e854f8e Compare May 31, 2026 16:27
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 31, 2026
Send-side machinery for mobile push notifications (LOBE-8771), stacked
on top of the schema PR (#15186).

### tRPC
- `pushToken.register` / `pushToken.unregister` exposed on both
  `MobileRouter` and `LambdaRouter`.

### `PushChannel`
- Structurally compatible with cloud's `NotificationChannel` so cloud
  can register it without casts.
- Fans a single notification out to all of a user's tokens, chunks via
  `expo-server-sdk`, respects the 600 msg/sec project limit with 100ms
  throttle between chunks.
- Embeds `(ticketId, expoToken)` pairs in `providerMessageId` for
  receipt reconciliation.
- Returns `no_tokens` / `invalid_tokens` / `rate_limited` /
  `all_send_failed` so callers can distinguish.

### `processPushReceipts`
- Pure helper to be called by cloud's Vercel cron (companion PR).
- Polls Expo receipts in parallel (`Promise.all` across chunks),
  updates `notification_deliveries` in bulk, prunes `push_tokens` rows
  flagged `DeviceNotRegistered`.
- Configurable lookback window + min-age guard (default: 24h / 15min).

### Dev tooling
- `/api/dev/test-push` (404s in production) lets you fire a real push
  directly to a user's registered tokens, bypassing `NotificationService`.
  Useful for end-to-end verification before cloud submodule sync.

### Types
- `NotificationSettings` gains an optional `push` channel.

Tests: 21 added (router 7, PushChannel 7, processPushReceipts 7).

Linear: https://linear.app/lobehub/issue/LOBE-8771

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sudongyuer sudongyuer force-pushed the sudongyuer/push-business-layer branch from e854f8e to a4c3e20 Compare May 31, 2026 17:03
@sudongyuer

Copy link
Copy Markdown
Collaborator Author

Thanks @chatgpt-codex-connector for the review. Addressed in a4c3e20:

P1 — premature delivered finalization ✅ fixed

Previously a delivery with mixed receipt states (some ok, some not-yet-returned by Expo) would be finalized as delivered because errors.length === 0 ignored pending tickets. That meant later error receipts (e.g. DeviceNotRegistered) were never processed and invalid tokens never cleaned up.

Fixed by gating on pendingCount === 0 before either delivered or failed path — partial deliveries now stay in sent for the next cron cycle. Added a regression test (leaves delivery in sent state when only some tickets have receipts).

P2 — migration idempotency — stale, no longer in this PR

The push_tokens migration was already merged into canary via the batch DB PR #15280 (0104_add_devices_connectors_push_tokens.sql). The Codex review ran against an older commit (63649b9) before this PR was rebased; the current diff (a4c3e20) only includes the PushTokenModel + send-side machinery, no migration. No action needed here.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@sudongyuer sudongyuer merged commit 4d840e9 into canary May 31, 2026
39 of 42 checks passed
@sudongyuer sudongyuer deleted the sudongyuer/push-business-layer branch May 31, 2026 17:49
@arvinxx arvinxx mentioned this pull request Jun 3, 2026
arvinxx added a commit that referenced this pull request Jun 4, 2026
# 🚀 LobeHub Release (20260604)

**Release Date:** June 4, 2026  
**Since v2.2.1:** 88 merged PRs · 11 contributors

> This week brings Execution Devices out of the lab — run agents and
Claude Code on any configured local or remote machine — alongside Claude
Opus 4.8, token-usage analytics, and Page sharing.

---

## ✨ Highlights

- **Execution Devices** — Pick where an agent runs. Desktop and CLI
devices auto-register with a stable machine ID, route through the
gateway by channel, and surface a device switcher in the chat input. Run
remote Claude Code on a configured device, with a recent-directory
picker you can drag to reorder. (#15300, #15315, #15322, #15343, #15351,
#15371)
- **Claude Opus 4.8** — Day-one support for Anthropic's latest model.
(#15314)
- **Token-usage analytics** — A new token-usage mode on the activity
heatmap, backed by a denormalized topic usage/cost rollup so totals stay
accurate without recomputing from messages. (#15365, #15417, #15425)
- **Page sharing** — Share a Page through a dedicated document share
flow, plus new Workspace and Agent share tables. (#15309, #15439)
- **Self-iteration agents** — Agent Signal's execAgent migration lands a
server-runtime bridge, async memory writer, and a registered
self-iteration tool package, with a CLI trigger command for testing.
(#15360, #15364, #15392)
- **Knowledge search** — BM25 search now extends to file-backed
documents, and the portal ships an editable CodeMirror viewer for local
files with document highlighting. (#15247, #15298)

---

## 🏗️ Core Agent & Architecture

### Agent Signal & Runtime

- **execAgent migration** — Server-runtime bridge, completion
projection, async memory writer, and removal of the legacy
`executeSelfIteration` path. (#15392)
- Registered the self-iteration builtin tool package and restored the
three mode-specific self-iteration agent slugs. (#15202, #15364)
- Added a CLI trigger command with a golden-snapshot fixture for Agent
Signal. (#15360)
- **Skill priority** — Agent Builder now emits a skill-priority
instruction with matching server runtime. (#15409)
- Retry empty LLM completions instead of silently finishing the turn.
(#15355)
- Classify topic/agent/session foreign-key violations as
`ConversationParentMissing` for clearer recovery. (#15408)
- Persist canonical nested usage/performance on assistant messages, and
re-link orphan tool messages at the raw bucket write boundary. (#15359,
#15438)
- Guard `createAgent` against LLM double-encoded array fields. (#15381)

---

## 🖥️ Execution Devices & Gateway

- Auto-register desktop and CLI devices with a stable machine ID, and
add the `@lobechat/device-identity` package. (#15300, #15321)
- New Devices settings page behind the Execution Device Switcher lab,
with a device switcher shown for all agents in the chat input. (#15315,
#15371)
- `connectionId` + channel routing across the gateway client and device
list; preset the local device on the first LLM request for the 本机
target. (#15322, #15435)
- Run remote Claude Code on a configured device, with drag-to-reorder
recent-directory management and client renders for device tool results.
(#15343, #15351, #15437)
- Preserve content and state across gateway tool calls, and prevent
duplicate streaming from stale reconnects. (#15114, #15354)

---

## 🖥️ CLI & Desktop

- Preserve content/state for connect local file and shell tools; render
the `runCommand` tool result card. (#15441, #15442)
- New `lh topic view` command; CLI now auto-registers its device on
login, matching desktop. (#15340, #15377)
- Resolve CLI tools from the shell `PATH`, and clarify local command
session handling. (#15368, #15389)
- Relocate visual-ref helpers to `@lobechat/const` to fix a renderer
crash; upload `.blockmap` files to S3 for differential updates. (#15326,
#15369)
- Fix a market OAuth expiry that triggered the wrong re-login modal, and
kill dev child processes on parent shutdown. (#15246, #15290)

---

## 🗂️ Pages, Library & Knowledge

- Document share flow with business slot stubs, plus Workspace and Agent
share tables. (#15309, #15439)
- Export Agent profiles as Markdown, preserving an empty agent prompt on
export. (#15312, #15316)
- Editable CodeMirror viewer for local files with document highlighting;
BM25 search extended to file-backed documents. (#15247, #15298)
- Default new Agent-doc files to `.md` and preserve IME composition;
refresh folder data on slug switch and dedupe breadcrumb fetches.
(#15335, #15427)

---

## 💬 Chat & User Experience

- Group-by-status mode for the Topic sidebar; dropped the legacy
session→agentId compatibility path from Topic queries. (#15366, #15378)
- Restore editor focus after the file picker closes, and close the skill
dropdown before navigating to settings. (#15391, #15394)
- Strip markdown tokens from fallback Topic titles; keep an open
ActionBar popup when hovering another message. (#15303, #15372)
- Stabilize home starter loading and stop transliterating model names in
the home starter; show artifact source while streaming. (#15310, #15324,
#15386)
- Group the sidebar spacer with recents and agents. (#15373)

---

## 📊 Analytics, Tasks & Notifications

- Token-usage mode on the activity heatmap, backed by a denormalized
topic usage/cost rollup. (#15365, #15417, #15425)
- Push: new `PushChannel`, receipt cron, and `pushToken` tRPC API.
(#15233)
- Tasks now support file and image attachments. (#15141)

---

## 🧩 Models & Providers

- Support Claude Opus 4.8 and configurable model routing with starters.
(#15314, #15384)
- MiniMax M3: new model entry and an Anthropic video runtime. (#15380,
#15403)
- Add `intern-s2-preview` with `thinking_mode`, and `step-3.7-flash`
support. (#15308, #15317)
- Block disabling the official provider; fix default provider setup in
business mode. (#15379, #15382)

---

## 🎨 UI & Modals

- Migrate modals to `@lobehub/ui/base-ui` (LOBE-9711 + eval batch),
including the create-custom-model and feedback/changelog modals.
(#15401, #15416)
- Restructure confirmModal title and content across deletion flows;
polish the service-model form and migrate its Switch to base-ui.
(#15426, #15440)
- Wrap the BlueBubbles bridge config into a connection card; update
`@lobehub/ui` to v5.15.5. (#15325, #15342)

---

## 🔒 Reliability

- Replace hardcoded `session_context` values with template variables in
credentials. (#15352)
- Point `CHANGELOG_URL` to `/changelog`. (#15428)

---

## 👥 Contributors

Huge thanks to **11 contributors** who shipped **88 merged PRs** this
cycle.

@hezhijie0327 · @qybaihe · @sxjeru · @arvinxx · @Innei · @tjx666 ·
@lijian · @sudongyuer · @cy948 · @rivertwilight · @AmAzing129

Plus @lobehubbot and renovate[bot] for maintenance.

---

**Full Changelog**: v2.2.1...release/weekly-20260604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:mobile Mobile app size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant