📝 docs(spa-routes): document .desktop.{ts,tsx} variant pattern#15327
Merged
Conversation
Extend the spa-routes skill so agents catch all `.desktop` colocated variants under `src/routes/`, not just the desktopRouter pair. Adds a new "3b. Other .desktop variants" section listing the current known cases (settings componentMap, agent index, group index), spells out the drift risk for each, and lists the rules for editing/adding/ removing variant pairs. Also updates the skill description so the trigger glob covers `componentMap.desktop`, `index.desktop.tsx`, and `.desktop.tsx variant`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PrakrutR
added a commit
to PrakrutR/genhub-v2
that referenced
this pull request
May 30, 2026
Merges upstream/canary into main, resolving all conflicts in favor of upstream. Key changes pulled in from upstream include: - feat(page-share): document share flow with business slot stubs (lobehub#15309) - feat(device): connectionId + channel routing in gateway client & device list (lobehub#15322) - fix(desktop): upload .blockmap files to S3 for differential updates (lobehub#15326) - docs(spa-routes): document .desktop.{ts,tsx} variant pattern (lobehub#15327) - chore: update @lobehub/ui to v5.15.5 (lobehub#15325) - New builtin-tool skill and data-fetching-architecture skill added - Various skill/agent doc updates (i18n, linear, local-testing, store-data-structures, etc.) - Database model and repository updates (topic, userMemory models, bm25, search index) - Google createImage provider updates - Navigation layout hook updates - GitHub Actions workflow restored (issue-auto-comments.yml) All merge conflicts resolved by accepting upstream versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coooolfan
pushed a commit
to Coooolfan/lobehub
that referenced
this pull request
Jun 1, 2026
…ub#15327) Extend the spa-routes skill so agents catch all `.desktop` colocated variants under `src/routes/`, not just the desktopRouter pair. Adds a new "3b. Other .desktop variants" section listing the current known cases (settings componentMap, agent index, group index), spells out the drift risk for each, and lists the rules for editing/adding/ removing variant pairs. Also updates the skill description so the trigger glob covers `componentMap.desktop`, `index.desktop.tsx`, and `.desktop.tsx variant`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
None — internal agent-skill documentation only.
🔀 Description of Change
Extend the
spa-routesskill so coding agents catch all colocated.desktop.{ts,tsx}variants undersrc/routes/, not just thedesktopRouter.config.tsx/desktopRouter.config.desktop.tsxpair.Concretely:
.desktop.{ts,tsx}variants insidesrc/routes/listing the variant pattern: Vite's resolver swaps a<name>.desktop.{ts,tsx}for its base<name>.{ts,tsx}in Electron builds, so editing only one side silently breaks Electron.src/routes/(main)/settings/features/componentMap.ts×componentMap.desktop.ts(guarded bycomponentMap.sync.test.ts)src/routes/(main)/agent/index.tsx×index.desktop.tsxsrc/routes/(main)/group/index.tsx×index.desktop.tsxdescriptionso triggers also covercomponentMap.desktop,index.desktop.tsx, and.desktop.tsx variant— keeping the skill from missing relevant edits.🧪 How to Test
Skill content only; no runtime impact.
📸 Screenshots / Videos
N/A — markdown-only change.
📝 Additional Information
No code, build, or behavior change. This only updates
.agents/skills/spa-routes/SKILL.mdso future agent runs that touchsrc/routes/are reminded to check for and sync.desktop.{ts,tsx}siblings.