Skip to content

refactor(all): use atomic types#448

Merged
ijsong merged 1 commit intomainfrom
use_atomic_types
Jun 1, 2023
Merged

refactor(all): use atomic types#448
ijsong merged 1 commit intomainfrom
use_atomic_types

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented May 16, 2023

What this PR does

Use new atomic types instead of old atomic functions to avoid misuse of variables.

@ijsong ijsong requested a review from hungryjang as a code owner May 16, 2023 14:54
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented May 16, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong mentioned this pull request May 16, 2023
Closed
@ijsong ijsong self-assigned this May 16, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (common_logger_flags@2218a40). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@                  Coverage Diff                   @@
##             common_logger_flags     #448   +/-   ##
======================================================
  Coverage                       ?   63.27%           
======================================================
  Files                          ?      131           
  Lines                          ?    17898           
  Branches                       ?        0           
======================================================
  Hits                           ?    11325           
  Misses                         ?     6007           
  Partials                       ?      566

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This was referenced May 16, 2023
Merged
Merged
Merged
Merged
@ijsong ijsong marked this pull request as draft May 25, 2023 06:03
@ijsong ijsong mentioned this pull request May 25, 2023
Merged
@ijsong ijsong marked this pull request as ready for review May 25, 2023 06:08
@ijsong ijsong force-pushed the common_logger_flags branch from 2218a40 to 7efe407 Compare June 1, 2023 03:31
@ijsong ijsong force-pushed the use_atomic_types branch from d0a3868 to a0a3b16 Compare June 1, 2023 03:32
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from common_logger_flags to main June 1, 2023 05:27
@ijsong ijsong merged commit 7f30487 into main Jun 1, 2023
@ijsong ijsong deleted the use_atomic_types branch June 1, 2023 05:27
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijsong @codecov-commenter @hungryjang