perf(storagenode): remove backup from append request#412
Merged
Conversation
This was referenced Apr 11, 2023
Member
Author
This was referenced Apr 11, 2023
b1e0982 to
4e18b9d
Compare
4e18b9d to
063890f
Compare
hungryjang
reviewed
Apr 14, 2023
063890f to
b620d36
Compare
b620d36 to
c857535
Compare
c857535 to
0fa973d
Compare
This was referenced May 16, 2023
hungryjang
approved these changes
Jun 1, 2023
This PR removes the Backups fields from AppendRequest. Thus, it makes unmarshaling AppendRequest can be improved.
0fa973d to
f75ef55
Compare
Member
Author
Member
Author
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does
This PR removes the Backups fields from AppendRequest. Thus, it makes unmarshaling AppendRequest can
be improved.