Skip to content

feat(storagenode): add configurations for initial window size#451

Merged
ijsong merged 1 commit intomainfrom
grpc_server_initial_flow_control_window_size
Jun 4, 2023
Merged

feat(storagenode): add configurations for initial window size#451
ijsong merged 1 commit intomainfrom
grpc_server_initial_flow_control_window_size

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented May 19, 2023

What this PR does

This PR adds new gRPC initial flow control window size options to the storage node.

  • --server-initial-conn-window-size
  • --server-initial-stream-window-size

Anything else

See:

@ijsong ijsong requested a review from hungryjang as a code owner May 19, 2023 12:15
This was referenced May 19, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented May 19, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong self-assigned this May 19, 2023
@ijsong ijsong marked this pull request as draft May 19, 2023 12:16
@ijsong ijsong marked this pull request as ready for review May 22, 2023 03:26
@ijsong ijsong mentioned this pull request May 23, 2023
Merged
@ijsong ijsong marked this pull request as draft May 25, 2023 06:04
@ijsong ijsong mentioned this pull request May 25, 2023
Merged
@ijsong ijsong marked this pull request as ready for review May 25, 2023 06:08
@ijsong ijsong force-pushed the append_partial_success branch from b93c628 to d728673 Compare June 1, 2023 03:32
@ijsong ijsong force-pushed the grpc_server_initial_flow_control_window_size branch from 82c1e97 to 3d0cdbf Compare June 1, 2023 03:32
@ijsong ijsong force-pushed the append_partial_success branch from d728673 to d83347c Compare June 1, 2023 06:08
@ijsong ijsong force-pushed the grpc_server_initial_flow_control_window_size branch from 3d0cdbf to c2e0d4d Compare June 1, 2023 06:08
@ijsong ijsong force-pushed the append_partial_success branch from d83347c to 9c0f857 Compare June 1, 2023 23:47
@ijsong ijsong force-pushed the grpc_server_initial_flow_control_window_size branch from c2e0d4d to dd3061c Compare June 1, 2023 23:47
@ijsong ijsong mentioned this pull request Jun 2, 2023
Merged
@ijsong
feat(storagenode): add configurations for initial window size
8b623b0 
This PR adds new gRPC initial flow control window size options to the storage node.

- `--server-initial-conn-window-size`
- `--server-initial-stream-window-size`

See:
- https://httpwg.org/specs/rfc7540.html#InitialWindowSize
- https://pkg.go.dev/google.golang.org/grpc#InitialConnWindowSize
@ijsong ijsong force-pushed the append_partial_success branch from 9c0f857 to 5d438bb Compare June 4, 2023 07:37
@ijsong ijsong mentioned this pull request Jun 4, 2023
Merged
@ijsong ijsong force-pushed the grpc_server_initial_flow_control_window_size branch from dd3061c to 8b623b0 Compare June 4, 2023 07:37
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 4, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from append_partial_success to main June 4, 2023 08:01
@ijsong ijsong merged commit 5269481 into main Jun 4, 2023
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 4, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong deleted the grpc_server_initial_flow_control_window_size branch June 4, 2023 08:01
@ijsong ijsong mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijsong @hungryjang