feat(storagenode): change append rpc from unary to stream#449
Merged
Conversation
This was referenced May 16, 2023
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced May 16, 2023
3 tasks
2cea668 to
02b62ce
Compare
e50b226 to
ae21296
Compare
hungryjang
approved these changes
Jun 2, 2023
Member
hungryjang
left a comment
There was a problem hiding this comment.
It has already been made into an issue, but I hope the stream can be reused.
This PR changes the Append RPC lifestyle from a unary to a bidirectional stream. However, it neither adds nor updates stream-styled Append. Therefore, this change is transparent for users. This is starting point to support streaming Append API, and LocalOrderClient mentioned on #433.
ae21296 to
5b27a18
Compare
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR changes the Append RPC lifestyle from a unary to a bidirectional stream. However, it neither
adds nor updates stream-styled Append. Therefore, this change is transparent for users.
This is starting point to support streaming Append API, and LocalOrderClient mentioned on #433.