Skip to content

feat(client): add LogStreamAppender#459

Merged
ijsong merged 1 commit intomainfrom
log_stream_appender
Jun 7, 2023
Merged

feat(client): add LogStreamAppender#459
ijsong merged 1 commit intomainfrom
log_stream_appender

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented May 25, 2023

What this PR does

This PR adds LogStreamAppender to the client, and it is a client to append asynchronously only a particular log stream.

Which issue(s) this PR resolves

Resolves #433

This was referenced May 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented May 25, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong linked an issue May 25, 2023 that may be closed by this pull request
storagenode,client: introduce LogStreamAppender #433
Closed
3 tasks
@ijsong ijsong mentioned this pull request May 25, 2023
Closed
3 tasks
@ijsong ijsong marked this pull request as ready for review May 25, 2023 06:08
@ijsong ijsong requested a review from hungryjang as a code owner May 25, 2023 06:08
@ijsong ijsong marked this pull request as draft May 25, 2023 06:09
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 26.04% and project coverage change: -0.52 ⚠️

Comparison is base (80abf51) 63.15% compared to head (73006e6) 62.63%.

❗ Current head 73006e6 differs from pull request most recent head 62067e9. Consider uploading reports for the commit 62067e9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##           pipelined_append_handler     #459      +/-   ##
============================================================
- Coverage                     63.15%   62.63%   -0.52%     
============================================================
  Files                           132      133       +1     
  Lines                         18145    18336     +191     
============================================================
+ Hits                          11459    11485      +26     
- Misses                         6120     6277     +157     
- Partials                        566      574       +8
Impacted Files Coverage Δ
internal/storagenode/client/log_client.go 48.80% <0.00%> (-0.80%) ⬇️
pkg/varlog/config.go 50.79% <0.00%> (-40.64%) ⬇️
pkg/varlog/log.go 0.00% <0.00%> (ø)
pkg/varlog/log_stream_appender.go 0.00% <0.00%> (ø)
pkg/varlogtest/log.go 75.54% <92.59%> (+2.88%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong self-assigned this May 25, 2023
@ijsong ijsong force-pushed the log_stream_appender branch 5 times, most recently from 73006e6 to 62067e9 Compare May 30, 2023 10:35
@ijsong ijsong marked this pull request as ready for review May 30, 2023 10:36
@ijsong ijsong force-pushed the pipelined_append_handler branch from 80abf51 to 0579220 Compare June 1, 2023 03:32
@ijsong ijsong force-pushed the log_stream_appender branch from 62067e9 to 50ccc7b Compare June 1, 2023 03:32
@ijsong ijsong force-pushed the pipelined_append_handler branch from 0579220 to 918f845 Compare June 1, 2023 06:08
@ijsong ijsong force-pushed the log_stream_appender branch from 50ccc7b to e1468e4 Compare June 1, 2023 06:08
@ijsong ijsong force-pushed the pipelined_append_handler branch from 918f845 to 5bc3f8b Compare June 1, 2023 23:47
@ijsong ijsong force-pushed the log_stream_appender branch from e1468e4 to 05f590e Compare June 1, 2023 23:47
This was referenced Jun 2, 2023
Merged
Merged
@ijsong ijsong force-pushed the pipelined_append_handler branch from 5bc3f8b to 20e31e7 Compare June 4, 2023 07:37
@ijsong ijsong force-pushed the log_stream_appender branch from 05f590e to ea02918 Compare June 4, 2023 07:37
@ijsong ijsong force-pushed the pipelined_append_handler branch from 20e31e7 to 4ff8d8c Compare June 4, 2023 08:05
@ijsong ijsong force-pushed the log_stream_appender branch from ea02918 to f8a7676 Compare June 4, 2023 08:05
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 7, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from pipelined_append_handler to main June 7, 2023 16:45
@ijsong
feat(client): add LogStreamAppender
dec3421 
This PR adds LogStreamAppender to the client, and it is a client to append asynchronously only a
particular log stream.

Resolves #433.
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 7, 2023

Graphite rebased this pull request as part of a merge.

@ijsong ijsong merged commit bfe88d7 into main Jun 7, 2023
@ijsong ijsong deleted the log_stream_appender branch June 7, 2023 17:01
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 7, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storagenode,client: introduce LogStreamAppender

3 participants

@ijsong @codecov-commenter @hungryjang