Skip to content

perf(storagenode): check log level#411

Merged
ijsong merged 1 commit intomainfrom
check_log_level
Jun 1, 2023
Merged

perf(storagenode): check log level#411
ijsong merged 1 commit intomainfrom
check_log_level

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Apr 11, 2023

What this PR does

This PR slightly improves the storage node's performance by checking the log level, making the
logger not make slices in advance.

Copy link
Copy Markdown
Member

@hungryjang hungryjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how much it helps performance, but it seems to be very poor in usability.

@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 14, 2023

I don't know how much it helps performance, but it seems to be very poor in usability.

Yeah, it is too micro-optimization to recognize it.

This PR slightly improves the storage node's performance by checking the log level, making the
logger not make slices in advance.
@ijsong ijsong force-pushed the bump_etcd_version branch from 243fc84 to f676f1c Compare June 1, 2023 03:31
@ijsong ijsong force-pushed the check_log_level branch from e1fd68f to 39cdbae Compare June 1, 2023 03:31
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from bump_etcd_version to main June 1, 2023 05:26
@ijsong ijsong merged commit da1409d into main Jun 1, 2023
@ijsong ijsong deleted the check_log_level branch June 1, 2023 05:26
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants