Conversation
This was referenced Apr 11, 2023
Member
Author
This was referenced Apr 11, 2023
hungryjang
approved these changes
Apr 14, 2023
Member
hungryjang
left a comment
There was a problem hiding this comment.
I don't know how much it helps performance, but it seems to be very poor in usability.
Member
Author
Yeah, it is too micro-optimization to recognize it. |
This was referenced May 16, 2023
This PR slightly improves the storage node's performance by checking the log level, making the logger not make slices in advance.
Member
Author
Member
Author
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does
This PR slightly improves the storage node's performance by checking the log level, making the
logger not make slices in advance.