Skip to content

refactor(storagenode): simplify unary RPC logging#413

Merged
ijsong merged 1 commit intomainfrom
unary_rpc_logging
Jun 1, 2023
Merged

refactor(storagenode): simplify unary RPC logging#413
ijsong merged 1 commit intomainfrom
unary_rpc_logging

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Apr 11, 2023

No description provided.

@ijsong ijsong requested a review from hungryjang as a code owner April 11, 2023 08:04
This was referenced Apr 11, 2023
Merged
Merged
Merged
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 11, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong mentioned this pull request Apr 11, 2023
Merged
@ijsong ijsong self-assigned this Apr 11, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (remove_backup_from_append_request@b1e0982). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@                         Coverage Diff                          @@
##             remove_backup_from_append_request     #413   +/-   ##
====================================================================
  Coverage                                     ?   63.26%           
====================================================================
  Files                                        ?      131           
  Lines                                        ?    17815           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?    11271           
  Misses                                       ?     5989           
  Partials                                     ?      555
Impacted Files Coverage Δ
internal/storagenode/storagenode.go 73.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the remove_backup_from_append_request branch from b1e0982 to 4e18b9d Compare April 13, 2023 13:23
@ijsong ijsong force-pushed the unary_rpc_logging branch from 51494e9 to d928d2c Compare April 13, 2023 13:23
@ijsong ijsong force-pushed the remove_backup_from_append_request branch from 4e18b9d to 063890f Compare April 13, 2023 13:43
@ijsong ijsong force-pushed the unary_rpc_logging branch from d928d2c to 467ee59 Compare April 13, 2023 13:43
@ijsong ijsong force-pushed the remove_backup_from_append_request branch from 063890f to b620d36 Compare April 15, 2023 13:18
@ijsong ijsong force-pushed the unary_rpc_logging branch from 467ee59 to a7dd5e9 Compare April 15, 2023 13:18
@ijsong ijsong force-pushed the remove_backup_from_append_request branch from b620d36 to c857535 Compare April 25, 2023 12:13
@ijsong ijsong force-pushed the unary_rpc_logging branch from a7dd5e9 to 12e5586 Compare April 25, 2023 12:13
@ijsong ijsong force-pushed the remove_backup_from_append_request branch from c857535 to 0fa973d Compare May 16, 2023 14:54
@ijsong ijsong mentioned this pull request May 16, 2023
Merged
@ijsong ijsong force-pushed the unary_rpc_logging branch from 12e5586 to 017c6d7 Compare May 16, 2023 14:54
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ijsong ijsong marked this pull request as draft May 25, 2023 06:03
@ijsong ijsong mentioned this pull request May 25, 2023
Merged
@ijsong ijsong marked this pull request as ready for review May 25, 2023 06:08
@ijsong ijsong force-pushed the remove_backup_from_append_request branch from 0fa973d to f75ef55 Compare June 1, 2023 03:31
@ijsong ijsong force-pushed the unary_rpc_logging branch from 017c6d7 to b0787c4 Compare June 1, 2023 03:31
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from remove_backup_from_append_request to main June 1, 2023 05:27
@ijsong ijsong merged commit d74b811 into main Jun 1, 2023
@ijsong ijsong deleted the unary_rpc_logging branch June 1, 2023 05:27
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jun 1, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijsong @codecov-commenter @hungryjang