[4.1] Fix Image Size Check with scheduler by bembelimen · Pull Request #36653 · joomla/joomla-cms

bembelimen · 2022-01-12T12:03:47Z

Summary of Changes

Fix the resizing of the image with the scheduler task
Improve the description to make aware, that the file will be overwritten

Testing Instructions

Create a task from the type "Image Size Check"
Run it

Actual result BEFORE applying this Pull Request

Image sizes are not changed.

Expected result AFTER applying this Pull Request

Image sizes are changed.

brianteeman · 2022-01-12T12:35:16Z

I have tested this item 🔴 unsuccessfully on 4b49ad2

Resizes the first image found that is too big but then says its completed

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.}

chmst · 2022-01-12T12:54:36Z

I have tested this item ✅ successfully on 4b49ad2

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.}

bembelimen · 2022-01-12T13:02:57Z

I have tested this item red_circle unsuccessfully on 4b49ad2Resizes the first image found that is too big but then says its completed

It was always the intention to change one image per run to prevent any timeouts.

brianteeman · 2022-01-12T13:19:49Z

Then it must be clearly documented otherwise it will appear to be broken.

Although I have to say if it only does one image per run then it is pretty useless

bembelimen · 2022-01-12T20:05:54Z

Updated the PR to allow more than one image per run.

administrator/language/en-GB/plg_task_checkfiles.ini

plugins/task/checkfiles/forms/image_size.xml

administrator/language/en-GB/plg_task_checkfiles.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

plugins/task/checkfiles/checkfiles.php

plugins/task/checkfiles/forms/image_size.xml

administrator/language/en-GB/plg_task_checkfiles.ini

plugins/task/checkfiles/checkfiles.php

Co-authored-by: Quy <quy@fluxbb.org>

…cms into 4.1/fix-filesize-task # Conflicts: # administrator/language/en-GB/plg_task_checkfiles.ini

chmst · 2022-01-14T11:49:15Z

Now I get this error:

Folder Sample Data. Fresh installation of the full package.

chmst · 2022-01-14T16:08:45Z

Maybe only my local environment: ERROR Routine threw exception: The GD extension for PHP is not available.

drmenzelit · 2022-01-14T17:18:42Z

I have tested this item ✅ successfully on 99bbefd

Tested with 1 image, it works. Changed the settings to maximum images = 3, uploaded 4 big images, 3 where changed successfully on the next run. The 4th image was changed too in the next run.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.}

chmst · 2022-01-14T18:18:33Z

I have tested this item ✅ successfully on 99bbefd

Re-tested on web server and it works.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.}

drmenzelit · 2022-01-14T18:22:15Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.}

bembelimen · 2022-01-14T18:28:50Z

Thanks all for the feedback and the improvements.

bembelimen added 2 commits January 12, 2022 10:28

Fix file resize saving

bd8d075

Make aware that image resizer overwrites the original file

4b49ad2

joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 12, 2022

Implement number of images options for resizer task

492c50b

brianteeman reviewed Jan 12, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkfiles.ini Outdated Show resolved Hide resolved

brianteeman reviewed Jan 12, 2022

View reviewed changes

plugins/task/checkfiles/forms/image_size.xml Show resolved Hide resolved

tecpromotion reviewed Jan 12, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkfiles.ini Outdated Show resolved Hide resolved

bembelimen and others added 2 commits January 12, 2022 23:38

Add description to resize task parameter

34a4fa1

Update administrator/language/en-GB/plg_task_checkfiles.ini

a03e18e

Co-authored-by: Brian Teeman <brian@teeman.net>

bembelimen commented Jan 13, 2022

View reviewed changes

plugins/task/checkfiles/checkfiles.php Outdated Show resolved Hide resolved

Remove empty line

b22e944

Quy reviewed Jan 13, 2022

View reviewed changes

plugins/task/checkfiles/forms/image_size.xml Outdated Show resolved Hide resolved

bembelimen commented Jan 13, 2022

View reviewed changes

plugins/task/checkfiles/forms/image_size.xml Outdated Show resolved Hide resolved

Update plugins/task/checkfiles/forms/image_size.xml

3177a1a

Quy reviewed Jan 13, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkfiles.ini Outdated Show resolved Hide resolved

Quy reviewed Jan 13, 2022

View reviewed changes

plugins/task/checkfiles/checkfiles.php Outdated Show resolved Hide resolved

bembelimen and others added 3 commits January 13, 2022 17:44

Update plugins/task/checkfiles/checkfiles.php

3323a72

Co-authored-by: Quy <quy@fluxbb.org>

Remove dimension from language string

25ac763

Merge branch '4.1/fix-filesize-task' of github.com:bembelimen/joomla-…

99bbefd

…cms into 4.1/fix-filesize-task # Conflicts: # administrator/language/en-GB/plg_task_checkfiles.ini

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 14, 2022

bembelimen merged commit 4e191c9 into joomla:4.1-dev Jan 14, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2022

bembelimen added this to the Joomla 4.1.0 milestone Jan 14, 2022

jgerman-bot mentioned this pull request Jan 14, 2022

[4.1] Fix Image Size Check with scheduler joomlagerman/joomla#2222

Closed

joomlapl-bot mentioned this pull request Jan 14, 2022

[4.1] Fix Image Size Check with scheduler JoomlaPolska/jezyk-J4#117

Closed

bembelimen deleted the 4.1/fix-filesize-task branch March 15, 2024 00:08

Uh oh!

Conversation

bembelimen commented Jan 12, 2022 • edited by drmenzelit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Uh oh!

brianteeman commented Jan 12, 2022

Uh oh!

chmst commented Jan 12, 2022

Uh oh!

bembelimen commented Jan 12, 2022

Uh oh!

brianteeman commented Jan 12, 2022

Uh oh!

bembelimen commented Jan 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chmst commented Jan 14, 2022

Uh oh!

chmst commented Jan 14, 2022

Uh oh!

drmenzelit commented Jan 14, 2022

Uh oh!

chmst commented Jan 14, 2022

Uh oh!

drmenzelit commented Jan 14, 2022

Uh oh!

bembelimen commented Jan 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bembelimen commented Jan 12, 2022 •

edited by drmenzelit

Loading