[4.1] Scheduled tasks notes#36244
Merged
bembelimen merged 4 commits intojoomla:4.1-devfrom Dec 13, 2021
Merged
Conversation
If a task has a note then it is displayed below the task name inside a small span (just like in all other components) If a task does not have a note then a small span is still present but it contains a language string (which is empty) There is no need for this empty span and there is certainly no need for a language string with no content. ## To test Create a new task with a note Create another new task without a note Check the source code and you will see the empty span on the second task Apply this PR Refresh and check the source of the page again. This time there is no empty span on the task without a note and the note is still displayed on the other task.
Quy
reviewed
Dec 6, 2021
| @@ -201,9 +201,7 @@ class="js-draggable" data-url="<?php echo $saveOrderingUrl; ?>" data-direction=" | |||
| <?php endif; ?> | |||
|
|
|||
| <span class="small"> | |||
Contributor
There was a problem hiding this comment.
Please move inside the if statement to not have an empty span when no note.
Contributor
Author
There was a problem hiding this comment.
Sorry - that was the whole point of this pr - doh
Contributor
|
I have tested this item ✅ successfully on 0ce9a11 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244. |
Member
|
@brianteeman Couldn't the "COM_SCHEDULER_NO_NOTE" string be removed from the language file? As far as I can see it is not used anymore after the change here. |
Contributor
Author
|
@richard67 it is removed |
Member
|
Oh, how could I miss that. |
Contributor
|
I have tested this item ✅ successfully on d807091 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244. |
Contributor
|
Thx |
Contributor
Author
|
thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jan 22, 2022
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a task has a note then it is displayed below the task name inside a small span (just like in all other components)
If a task does not have a note then a small span is still present but it contains a language string (which is empty)
There is no need for this empty span and there is certainly no need for a language string with no content.
To test
Create a new task with a note
Create another new task without a note
Check the source code and you will see the empty span on the second task
Apply this PR
Refresh and check the source of the page again. This time there is no empty span on the task without a note and the note is still displayed on the other task.