[4.1] Prevent disabling a parent template when children exist#36192
Merged
bembelimen merged 3 commits intojoomla:4.1-devfrom Dec 7, 2021
Hidden character warning
The head ref may contain hidden characters: "4.1-dev\u2014disable-parent-template"
Merged
[4.1] Prevent disabling a parent template when children exist#36192bembelimen merged 3 commits intojoomla:4.1-devfrom
bembelimen merged 3 commits intojoomla:4.1-devfrom
Conversation
Quy
reviewed
Dec 4, 2021
administrator/components/com_installer/src/Model/ManageModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on f00ce49 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192. |
PhilETaylor
reviewed
Dec 4, 2021
administrator/components/com_installer/src/Model/ManageModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor
|
I have tested this item ✅ successfully on 7f08205 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192. |
Contributor
|
Thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jan 22, 2022
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
To prevent a possible disaster (disabling a parent template but child still around and default) a simple check was added in the installer component. (FWIW if a parent is disabled the child template is fully functional for the Cassiopeia but if a template also disables some plugins, etc then it might break)
Testing Instructions
Actual result BEFORE applying this Pull Request
A parent template could be disabled although there might be children
Expected result AFTER applying this Pull Request
Disabling is not possible if children exist
Documentation Changes Required