[4.1] Unification of the language com_scheduler, part 3 by tecpromotion · Pull Request #36297 · joomla/joomla-cms

tecpromotion · 2021-12-12T14:50:13Z

Summary of Changes

During the translation into German and testing, an error occurred in the display of the duration time.

This PR shows the correct output.

Testing Instructions

create a new taks an click Run Test.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

.

brianteeman · 2021-12-12T14:51:12Z

ouch - I made that change and none of the testers spotted it

tecpromotion · 2021-12-12T14:53:56Z

ouch - I made that change and none of the testers spotted it

yes, unfortunately i didn't test that enough with my team when beta1 was released. but we should test it thoroughly again before the stable release.

Quy · 2021-12-13T13:19:38Z

I have tested this item ✅ successfully on 8474a84

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.}

Quy · 2021-12-13T13:20:31Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.}

khu5h1 · 2021-12-14T12:03:27Z

I have tested this item ✅ successfully on 8474a84

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.}

Shubhamverma2796 · 2021-12-22T13:33:30Z

I have tested this item ✅ successfully on 8474a84

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.}

wojsmol · 2021-12-22T13:46:11Z

@tecpromotion Please use %f instead.

richard67 · 2021-12-30T09:23:09Z

@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.

tecpromotion · 2021-12-30T10:26:33Z

@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.

I can check this later.

tecpromotion · 2021-12-30T17:49:53Z

@tecpromotion Please use %f instead.

@wojsmol Sorry but '%f' does not work here.

joomla-cms/build/media_source/com_scheduler/js/admin-view-run-test-task.es6.js

Line 60 in b76ec55

    
           modal.querySelector('.modal-body > div').innerHTML += `<div>${Joomla.Text._('COM_SCHEDULER_TEST_RUN_DURATION').replace('%s', output.data.duration.toFixed(2))}</div>`;

Here a '%s' is searched for and replaced.

Change both to %f does not work.

richard67 · 2021-12-30T19:07:15Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.}

bembelimen · 2021-12-31T12:55:34Z

Thx

alikon · 2021-12-31T16:43:36Z

merged ? !!!!
why ? 🤕
evidently feedback from some are not welcomed or better simply ignored

richard67 · 2021-12-31T16:48:29Z

@alikon Why ignored? @tecpromotion has checked with "%s" as requested and has reported back why we can't do that with the js as it is now.

alikon · 2021-12-31T16:52:24Z

this doesn't prove it's correct

tecpromotion · 2022-01-05T13:27:41Z

this doesn't prove it's correct

You're absolutely right, but that doesn't solve the problem.
A developer has to sit down and fix it everywhere.
Now there is an output and no more error.

fix string

8474a84

joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 12, 2021

Quy removed the Language Change This is for Translators label Dec 13, 2021

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 13, 2021

alikon suggested changes Dec 13, 2021

View reviewed changes

Comment thread administrator/language/en-GB/com_scheduler.ini

richard67 added this to the Joomla 4.1 milestone Dec 17, 2021

Quy removed the RTC This Pull Request is Ready To Commit label Dec 22, 2021

joomla-cms-bot removed this from the Joomla 4.1 milestone Dec 22, 2021

richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 24, 2021

brianteeman mentioned this pull request Dec 28, 2021

[4.1 ScheduledTasks] - %s seconds duration #36450

Closed

richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 30, 2021

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 30, 2021

richard67 added this to the Joomla 4.1 milestone Dec 30, 2021

Merge branch '4.1-dev' into unification-wording-com-scheduler-part-3

044a4ca

joomla-cms-bot added the Language Change This is for Translators label Dec 30, 2021

bembelimen added 2 commits December 31, 2021 10:52

Merge branch '4.1-dev' into unification-wording-com-scheduler-part-3

d383310

Merge branch '4.1-dev' into unification-wording-com-scheduler-part-3

ac88cd7

bembelimen merged commit 0bb543b into joomla:4.1-dev Dec 31, 2021

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 31, 2021

jgerman-bot mentioned this pull request Dec 31, 2021

[4.1] Unification of the language com_scheduler, part 3 joomlagerman/joomla#2197

Closed

joomlapl-bot mentioned this pull request Dec 31, 2021

[4.1] Unification of the language com_scheduler, part 3 JoomlaPolska/jezyk-J4#105

Closed

tecpromotion deleted the unification-wording-com-scheduler-part-3 branch January 5, 2022 13:26

Uh oh!

Conversation

tecpromotion commented Dec 12, 2021

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

brianteeman commented Dec 12, 2021

Uh oh!

tecpromotion commented Dec 12, 2021

Uh oh!

Quy commented Dec 13, 2021

Uh oh!

Quy commented Dec 13, 2021

Uh oh!

Uh oh!

khu5h1 commented Dec 14, 2021

Uh oh!

Shubhamverma2796 commented Dec 22, 2021

Uh oh!

wojsmol commented Dec 22, 2021

Uh oh!

richard67 commented Dec 30, 2021

Uh oh!

tecpromotion commented Dec 30, 2021

Uh oh!

tecpromotion commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Dec 30, 2021

Uh oh!

bembelimen commented Dec 31, 2021

Uh oh!

alikon commented Dec 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Dec 31, 2021

Uh oh!

alikon commented Dec 31, 2021

Uh oh!

tecpromotion commented Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tecpromotion commented Dec 30, 2021 •

edited

Loading

alikon commented Dec 31, 2021 •

edited

Loading